Closed Bug 1057155 Opened 6 years ago Closed 6 years ago

Remote runtime errors on cancel

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

If you cancel the remote runtime dialog, it still tries to connect anyway, and shows you an error message.
This is a little tricky, as it's not easy to "cancel" a promise... so let me know if you see a better way.  Anyway, we want to stop the ongoing attempt to connect if the user cancels the dialog.

Try: https://tbpl.mozilla.org/?tree=Try&rev=17b7e4d2da03
Attachment #8477102 - Flags: review?(paul)
Attachment #8477102 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/c3cc191aafbd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.