Closed
Bug 1057155
Opened 10 years ago
Closed 10 years ago
Remote runtime errors on cancel
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(1 file)
3.12 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
If you cancel the remote runtime dialog, it still tries to connect anyway, and shows you an error message.
Assignee | ||
Comment 1•10 years ago
|
||
This is a little tricky, as it's not easy to "cancel" a promise... so let me know if you see a better way. Anyway, we want to stop the ongoing attempt to connect if the user cancels the dialog.
Try: https://tbpl.mozilla.org/?tree=Try&rev=17b7e4d2da03
Attachment #8477102 -
Flags: review?(paul)
Updated•10 years ago
|
Attachment #8477102 -
Flags: review?(paul) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•