Remote runtime errors on cancel

RESOLVED FIXED in Firefox 34

Status

RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 34

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
If you cancel the remote runtime dialog, it still tries to connect anyway, and shows you an error message.
(Assignee)

Comment 1

4 years ago
Created attachment 8477102 [details] [diff] [review]
Stop error on remote runtime cancel

This is a little tricky, as it's not easy to "cancel" a promise... so let me know if you see a better way.  Anyway, we want to stop the ongoing attempt to connect if the user cancels the dialog.

Try: https://tbpl.mozilla.org/?tree=Try&rev=17b7e4d2da03
Attachment #8477102 - Flags: review?(paul)

Updated

4 years ago
Attachment #8477102 - Flags: review?(paul) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/c3cc191aafbd
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c3cc191aafbd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.