Closed
Bug 1057156
Opened 11 years ago
Closed 11 years ago
[jsdbg2] Nothing calls GlobalObject::addDebugger
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
|
2.37 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
It's dead, Jim. But is it supposed to be? The cycle detection code depends on the debuggers set.
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(jimb)
|
||
Comment 1•11 years ago
|
||
It looks to me like the logic here does the same thing as GlobalObject::addDebugger:
https://hg.mozilla.org/mozilla-central/file/79ce51162e77/js/src/vm/Debugger.cpp#l2369
So I think it's just duplicated code.
Flags: needinfo?(jimb)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8479250 -
Flags: review?(jimb)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8479250 [details] [diff] [review]
Remove dead GlobalObject::addDebugger.
Review of attachment 8479250 [details] [diff] [review]:
-----------------------------------------------------------------
Hard to object to anything in this patch.
Attachment #8479250 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Assignee: nobody → shu
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•