105719 - nsObserverService::Notify can avoid QI/ADDREF

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

nsObserverService::Notify can avoid QI/ADDREF by accessing the nsObserverList's
nsISupportsArry directly.

Comment 1

[Alec Flett]

another suggestion is to move the notification logic into nsObserverList - by
adding a public method to notify observers in the list.

Comment 2

[Doug Turner (:dougt)]

also see 55228

also, we should set some state so that we do not have to QI every observer for a
weak reference.

Comment 3

[Doug Turner (:dougt)]

Attachment: draft patch.

Reduces QI and enumeration object create during notification.  Inital Perf
timing is about 1.5x faster although clocked time is < a 200 microsecond
difference.

Comment 4

[Doug Turner (:dougt)]

The perf delta is low.  Moving out

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Fixed by bug 326491, I believe.