navigator.mozHour12 should not have a default value.

RESOLVED FIXED in 2.1 S3 (29aug)

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

unspecified
2.1 S3 (29aug)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8477175 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23172

Hi Arthur,

Could you help to review the patch?

Thanks. :)
Attachment #8477175 - Flags: review?(arthur.chen)
(Assignee)

Updated

4 years ago
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S3 (29aug)
(Assignee)

Updated

4 years ago
Summary: navigator.mozHour12 should not have the default value. → navigator.mozHour12 should not have a default value.
Comment on attachment 8477175 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23172

I just thought that the script is for creating a shim for mozHour12 so it should at least have a default value "null" instead of leaving it as undefined. r=me with the comment addressed, thanks!
Attachment #8477175 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 3

4 years ago
Hi Arthur,

Sure, let's do "null" value.
(Assignee)

Comment 4

4 years ago
Thanks for the review, Arthur.
(Assignee)

Comment 5

4 years ago
master: https://github.com/mozilla-b2g/gaia/commit/92373277084cf33f1a5730c4b735d1e8c29ef58f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.