1057225 - Fix rounding issues causing slight gaps in MP4 time ranges.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Fragments can have a rounding error of 1 timescale unit per sample. This gets reported as a discontinuity in the buffered time ranges. It makes sense to wallpaper over this discontinuity because it is inconsequential.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix MP4 timestamp discontinuities due to rounding

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8477242 [details] [diff] [review]
Fix MP4 timestamp discontinuities due to rounding

Review of attachment 8477242 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/mp4_demuxer.cpp
@@ +252,5 @@
>    uint64_t offset = std::numeric_limits<uint64_t>::max();
>    for (int i = 0; i < mPrivate->mIndexes.Length(); i++) {
>      offset = std::min(offset, mPrivate->mIndexes[i]->GetEvictionOffset(aTime));
>    }
> +  return offset == std::numeric_limits<uint64_t>::max() ? 0 : offset;

0 is a valid offset. This should return -1.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cacfcfb3def

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cacfcfb3def