Closed Bug 1057328 Opened 5 years ago Closed 5 years ago

--app-override dist is broken with message "Could not find path to gmp-fake plugin!"

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file, 1 obsolete file)

Also broken on Linux.
OS: Mac OS X → All
Hardware: x86 → All
Summary: --app-override dist is broken (at least on OSX) with message "Could not find path to gmp-fake plugin!" → --app-override dist is broken with message "Could not find path to gmp-fake plugin!"
I don't feel happy about how I'm finding this path, but I don't know if we have a better way that deals with platform idiosyncracies... do we?
Attachment #8477367 - Flags: review?(ted)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8477367 [details] [diff] [review]
get gmp path for app-override tests,

Review of attachment 8477367 [details] [diff] [review]:
-----------------------------------------------------------------

r- because I think this will break when called in other ways. Should be easy to fix though.

::: testing/mochitest/mach_commands.py
@@ +360,5 @@
> +                options.app = self.get_binary_path(where='staged-package')
> +            elif app_override:
> +                options.app = app_override
> +            # Need to fix the location of gmp_fake which might not be shipped in the binary
> +            gmp_fake = self.get_binary_path(what='gmp-fake', validate_exists=False)

Alternately you could do:
bin_path = self.get_binary_path()
gmp_fake = os.path.join(os.path.dirname(bin_path), 'gmp-fake')

::: testing/mochitest/runtests.py
@@ +1161,5 @@
>  
>      return manifest
>  
>    def getGMPPluginPath(self, options):
> +    if options.gmp_path:

I think this is going to break in the non-app-override case, since nothing is setting this property. You can default it to None in mochitest_options.py.
Attachment #8477367 - Flags: review?(ted) → review-
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Comment on attachment 8477367 [details] [diff] [review]
> get gmp path for app-override tests,
> 
> Review of attachment 8477367 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r- because I think this will break when called in other ways. Should be easy
> to fix though.
> 
> ::: testing/mochitest/mach_commands.py
> @@ +360,5 @@
> > +                options.app = self.get_binary_path(where='staged-package')
> > +            elif app_override:
> > +                options.app = app_override
> > +            # Need to fix the location of gmp_fake which might not be shipped in the binary
> > +            gmp_fake = self.get_binary_path(what='gmp-fake', validate_exists=False)
> 
> Alternately you could do:
> bin_path = self.get_binary_path()
> gmp_fake = os.path.join(os.path.dirname(bin_path), 'gmp-fake')

This seems nicer.

> 
> ::: testing/mochitest/runtests.py
> @@ +1161,5 @@
> >  
> >      return manifest
> >  
> >    def getGMPPluginPath(self, options):
> > +    if options.gmp_path:
> 
> I think this is going to break in the non-app-override case, since nothing
> is setting this property. You can default it to None in mochitest_options.py.

Running this locally without passing any app-override works, actually... but defaulting it explicitly is probably a good idea anyway. :-)
Is this what you meant?
Attachment #8477406 - Flags: review?(ted)
Attachment #8477367 - Attachment is obsolete: true
Comment on attachment 8477406 [details] [diff] [review]
get gmp path for app-override tests,

Review of attachment 8477406 [details] [diff] [review]:
-----------------------------------------------------------------

Feels like overkill to have an actual commandline argument that nobody needs, but it's not a big deal.
Attachment #8477406 - Flags: review?(ted) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/ab38c3bfcb8f
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ab38c3bfcb8f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.