Closed Bug 1057339 Opened 5 years ago Closed 5 years ago

nsGlobalWindow::Focus compares innerwindow to outerwindow

Categories

(Core :: DOM: Core & HTML, defect)

29 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Duplicate of this bug: 1057405
Waiting for the tryserver results from https://bugzilla.mozilla.org/show_bug.cgi?id=874050#c30
That bug has also a test for this.
Attached patch v2Splinter Review
This should fix the assertion failure which happened when chrome js
explicitly set opener.
Attachment #8477506 - Attachment is obsolete: true
Attachment #8477593 - Flags: review?(bzbarsky)
Comment on attachment 8477593 [details] [diff] [review]
v2

r=me.  Sure do wish we always passed outers to OpenWindowInternal...
Attachment #8477593 - Flags: review?(bzbarsky) → review+
They looked ok, and the assertions would fire.
https://hg.mozilla.org/mozilla-central/rev/c4a6a177da57
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.