1057342 - "Open" button background is not displayed after an app is installed from consumer pages

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Iulian Timis]

Steps to reproduce:
1. Open MP feed dev landing page https://marketplace-feed-dev.allizom.org
2. Click on a listed collection.
3. Click the "Free" button and install an app.

Expected results:
After the app is installed, the button changes its label to "Open".

Actual results:
The install button is no longer displayed, the text is displayed but the background is missing. The button appears only if we navigate away, and back.

Notes/Issues:
Verified on FF34 (Win 7, Android 4.2.1) and FF OS 1.3.
Screencast for this issue http://screencast.com/t/Lb5wPkibv7cG

Comment 1

[Chuck Harmston [:chuck]]

It seems that this was intentional. Kevin?

https://github.com/mozilla/fireplace/commit/adf9b2ccfaafacd3d48ad8f73730c28e34305769

Comment 2

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/608

Comment 3

[krupa raj[:krupa]]

Button now disappears if install failed.

STR:
1. Load https://marketplace-feed-dev.allizom.org/feed/collection/welcome?src=collection-element
2. Install the app "Presefy"
3. Cancel the install confirmation on the browser

expected behavior:
After install cancel, the button reverts to "Free"

actual behavior:
The button disappears


screenshot: https://www.dropbox.com/s/tfdfm46c3iwulqh/Screenshot%202014-08-22%2012.40.30.png?dl=0

Comment 4

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/be99bab

Really good find. All these regressions are the result of increasing the click target bug...the payment button states may need a once-over also although I tried to address this in the logic already.

Comment 5

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/ on FF34 (Win 7).
Postfix screencast http://screencast.com/t/YjnJONjyo1z
Also, the button reverts its state to "Free" upon canceling the install.
Closing bug.