Closed
Bug 1057387
Opened 10 years ago
Closed 10 years ago
mach run --help shows + characters instead of - characters for command-specific option prefixes
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(2 files)
4.94 KB,
patch
|
Details | Diff | Splinter Review | |
3.82 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
------------------------------------------------------------------------------ kats@kgupta-air gecko$ mach run --help usage: mach [global arguments] run [command arguments] Run the compiled program. Global Arguments: -v, --verbose Print verbose output. -l FILENAME, --log-file FILENAME Filename to write log data to. --log-interval Prefix log line with interval from last message rather than relative time. Note that this is NOT execution time if there are parallel operations. --log-no-times Do not prefix log lines with times. By default, mach will prefix each output line with the time since command start. -h, --help Show this help message. Command Arguments: params Command-line arguments to pass to the program. +remote, +r Do not pass the -no-remote argument by default. +background, +b Do not pass the -foreground argument by default on Mac +profile, +P Specify the profile to use ------------------------------------------------------------------------------ See the "Command Arguments" section above, where it says "+remote, +r" and the like. That should be "-remote, -r". Attempting to run "mach run +P dummy" doesn't use my "dummy" profile, but "mach run -P dummy" does.
Assignee | ||
Comment 1•10 years ago
|
||
Sorry, I accidentally checked the security-sensitive checkbox before hitting submit, and I can't seem to undo it! :(
Updated•10 years ago
|
Group: core-security
Assignee | ||
Comment 2•10 years ago
|
||
I suppose the remote and background options might actually make sense as + since they are "do not pass ... argument by default" kinds of options (but still, weird). But the profile one should definitely be a - option.
Blocks: 1024471
Assignee | ||
Comment 3•10 years ago
|
||
My naive attempt to fix the argument didn't work for reasons I can't decipher somewhere in the bowels of argparse.
Assignee | ||
Comment 4•10 years ago
|
||
This seems like a better fix, as it aligns the documentation with what the code actually does.
Attachment #8477931 -
Flags: review?(gps)
Comment 5•10 years ago
|
||
Comment on attachment 8477931 [details] [diff] [review] Fix documentation Review of attachment 8477931 [details] [diff] [review]: ----------------------------------------------------------------- I think this will work. But profile handling for these commands has always been finicky. Be prepared for unexpected breakage.
Attachment #8477931 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/62e8be7789a3
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62e8be7789a3
Assignee: nobody → bugmail.mozilla
Target Milestone: --- → mozilla34
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Updated•2 years ago
|
Type: enhancement → defect
Component: Mach Core → General
You need to log in
before you can comment on or make changes to this bug.
Description
•