1057396 - Browser windows should display the page title in cards view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Browser windows should display the page title, whereas app windows display the app title. This is spec'd in https://mozilla.box.com/s/638ltapmruk7l0vo8mou, note that is applies to the carousel-style task switcher in lieu of the haida-style task strip being ready for 2.1

Comment 1

[Ben Francis [:benfrancis]]

Note that the sheets overlay seems to use the right title, it might just be a case of re-using that value from the window manager.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: PR to display page title for browser windows in cards view

Card instances listen for their app's namechange and titlechange to update the title. This means browser windows display the page title in cards view, as per Task Manager spec: https://mozilla.app.box.com/s/lbw2wzw3p4jvxs24k4sg

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

PR updated. This seems to do the right thing. Ben could you possibly take it for a spin? We aren't expecting real-time updates, so if a page changes its title while the cards view is showing it wont update in real time - which seems like an edge case and of dubious value to the user anyhow.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

Looks sane.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/8d051e3b074fd37674d0152f27761c39b54f4114
Commit: https://github.com/mozilla-b2g/gaia/commit/c162544a69d330f8223b3f6915d18bce521ef0bc

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

Yep, that seems to work. Thanks!

Comment 7

[Oliver Nelson [:oliverthor]]

Verifying fix for 3.0 (mozilla-central) on flame devices:
Results: Within Card View, apps display their app title above their respective cards, and browser windows display their browser title above their respective cards.

--------------------------------------------------
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
--------------------------------------------------
Repro: 5/5

Comment 8

[Oliver Nelson [:oliverthor]]

Referenced the TaskManager doc located here: https://mozilla.app.box.com/s/4pfp6y8pjhwojtt9yhl8/1/2243605137/20745078605/1
Page 15