Closed Bug 1057396 Opened 7 years ago Closed 7 years ago

Browser windows should display the page title in cards view

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
All
defect
Not set
normal

Tracking

(b2g-master verified)

VERIFIED FIXED
2.1 S3 (29aug)
Tracking Status
b2g-master --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [ft:systems-fe][systemsfe])

Attachments

(1 file)

Browser windows should display the page title, whereas app windows display the app title. This is spec'd in https://mozilla.box.com/s/638ltapmruk7l0vo8mou, note that is applies to the carousel-style task switcher in lieu of the haida-style task strip being ready for 2.1
Note that the sheets overlay seems to use the right title, it might just be a case of re-using that value from the window manager.
Card instances listen for their app's namechange and titlechange to update the title. This means browser windows display the page title in cards view, as per Task Manager spec: https://mozilla.app.box.com/s/lbw2wzw3p4jvxs24k4sg
Assignee: nobody → sfoster
Attachment #8477543 - Flags: review?(alive)
Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

PR updated. This seems to do the right thing. Ben could you possibly take it for a spin? We aren't expecting real-time updates, so if a page changes its title while the cards view is showing it wont update in real time - which seems like an edge case and of dubious value to the user anyhow.
Attachment #8477543 - Flags: feedback?(bfrancis)
Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

Looks sane.
Attachment #8477543 - Flags: review?(alive) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 8477543 [details] [review]
PR to display page title for browser windows in cards view

Yep, that seems to work. Thanks!
Attachment #8477543 - Flags: feedback?(bfrancis) → feedback+
Target Milestone: --- → 2.1 S3 (29aug)
Verifying fix for 3.0 (mozilla-central) on flame devices:
Results: Within Card View, apps display their app title above their respective cards, and browser windows display their browser title above their respective cards.

--------------------------------------------------
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
--------------------------------------------------
Repro: 5/5
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
You need to log in before you can comment on or make changes to this bug.