1057467 - Adblock Plus add-on's "Open blockable items" menu does not show blockable items when e10s is enabled

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

In bug 930787 comment 6, The 8472 reported:

> I tested FF Nightly 34.0a1 (2014-08-21), linux x64 with both ABP 2.6.4 and
> their current development build and browser.tabs.remote.autostart = true.
> 
> In neither case the "open blockable items" view showed any entries after
> loading a page.
> Disabling e10s restored functionality.

When I open the blockable items list with e10s enabled, I see the following errors in Firefox's Browser Console:

> unable to modify interposed property content sidebar.js:88
> TypeError: target.gBrowser is undefined RemoteAddonsParent.jsm:639

Comment 1

[Robert Johnston]

Also, it's not blocking anything - Ads are still in place and not blocked. Disabling e10s solves this issue. Using the latest published version: 2.6.4.3860

Comment 2

[Gingerbread Man]

> Adblock Plus add-on's "Open blockable items" menu does not show blockable items when e10s is enabled
(In reply to Robert Johnston from comment #1)
> Also, it's not blocking anything

I can reproduce the above in FDE, but not the latest Nightly.

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150521030204
Adblock Plus 2.6.9.3938

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150521004003
Adblock Plus 2.6.9.3938

Comment 3

[Gingerbread Man]

In the FDE build from 2015-05-23, the Blockable Items Pane is no longer empty, and content is actually blocked.
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=0555aa58d0d5&tochange=e1f8abe63e21

However, keeping the Blockable Items Pane open while attempting to load a page makes CPU usage shoot through the roof. The slowdown is such that the page practically doesn't load. The Browser Console is flooded with, “unsafe CPOW usage”.

Comment 4

[Wladimir Palant]

I can reproduce neither issue with 42.0a1 nightly (2015-07-22) and Adblock Plus 2.6.9.3965 development build. Blockable items work, performance could be better but is still acceptable.

Comment 5

[Jerod Lycett]

The latest version on AMO appears to have fixed this issue.

Comment 6

[Wladimir Palant]

No, it didn't. The issue turned out to be a garbage collection problem. Blockable items show data attached to DOM nodes via WeakMap. With E10S WeakMap key are no longer DOM nodes but rather the corresponding CPOWs. CPOWs can be garbage collected because there are no further references to them - and eventually they will be, meaning that the data will be lost.

No simple solutions here, we need to attach the data in the content process rather than via CPOWs.

Comment 7

[Wladimir Palant]

This should be resolved in Adblock Plus 2.7 which was released a week ago.

Comment 8

[mkdante381]

(In reply to Wladimir Palant from comment #7)
> This should be resolved in Adblock Plus 2.7 which was released a week ago.

Not work in latest beta Firefox 44.0b2. ABP 2.7.0 stable or latest developer "Open blockable items" menu does not show blockable items when e10s is enabled. Activate e10s work in beta:
browser.tabs.remote;true brak ust
browser.tabs.remote.autostart;true
browser.tabs.remote.autostart.1;false
browser.tabs.remote.autostart.2;false
browser.tabs.remote.disabled-for-a11y;false

Comment 9

[mkdante381]

(In reply to mkdante381 from comment #8)
> (In reply to Wladimir Palant from comment #7)
> > This should be resolved in Adblock Plus 2.7 which was released a week ago.
> 
> Not work in latest beta Firefox 44.0b2. ABP 2.7.0 stable or latest developer
> "Open blockable items" menu does not show blockable items when e10s is
> enabled. Activate e10s work in beta:
> browser.tabs.remote;true brak ust
> browser.tabs.remote.autostart;true
> browser.tabs.remote.autostart.1;false
> browser.tabs.remote.autostart.2;false
> browser.tabs.remote.disabled-for-a11y;false

This is not fixed on FF44beta. When it would be fixed?

Comment 10

[Wladimir Palant]

That's a very different issue. Adblock Plus is still relying on compatibility shims in a few places, in this particular place on the availability of tabbrowser.contentWindow. This works in Firefox 46 but in Firefox 44 it returns null for some reason. The work required is covered by https://issues.adblockplus.org/ticket/3407.