1057481 - [E10S] Firefox restores all the previously open windows from the last session even when they were closed

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Achwaq Khalid]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140822030201

Comment 1

[Alice0775 White]

An error appears in Error Console when I close a window

Error: aWindow.content is null
Source File: resource:///modules/sessionstore/SessionStore.jsm
Line: 1007

Comment 2

[Alice0775 White]

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebffbc56b3a7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140820102420
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5650d84919fc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140820110915
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ebffbc56b3a7&tochange=5650d84919fc

Regressed by: 
25c918c5f3e1	Roberto A. Vitillo — Bug 559505 - Deprecate localstore.rdf and replace it with xulstore. r=enn, sr=bsmedberg CLOSED TREE

Comment 3

[Alice0775 White]

In my case, I can also reproduce in non-e10s...

Comment 4

[Alice0775 White]

Maybe the range of comment #2 is wrong

Comment 5

[Chris Peterson [:cpeterson]]

I was able to reproduce in non-e10s mode, but I still think this is an e10s bug. I think session store is not updated properly in e10s mode. When you switch the "browser.tabs.remote.autostart" pref to false and restart Firefox in non-e10s mode, the bad (e10s) session store is restored with closed windows. If you restart from non-e10s mode, then closed windows are not restored.

myfavoritebeer.org is a good test website because it opens a Persona login window.

Comment 6

[Alice0775 White]

Okay

Steps To Reproduce:
1. Open https://developer.mozilla.org/En/Code_snippets
2. Click "Signin with" > "Persona"
3. Login, then wait for automatic reload the page
4. Wait for 15sec to ensure saving session data (this step maybe not necessary)
5. Exit browser
6. Start Browser and Click "Restore Previous Session"

Regression widnow(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72f6354159d5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140820124716
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/304619045d61
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140820125117
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=72f6354159d5&tochange=304619045d61


In local build
Last Good: 06d5e509cdb4
First Bad: d6bdd3272ccb

Triggered by:
d6bdd3272ccb	Bill McCloskey — Bug 1051017 - Add browser.contentWindowAsCPOW and browser.contentDocumentAsCPOW (r=mconley,mrbkap)

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

An easier STR is to start a normal build (non-e10s) and open an e10s window. If closing the e10s-window causes an error message in the console that says "aWindow.content is null" then sessionstore will fail too.

Comment 8

[Alice0775 White]

(In reply to Tim Taubert [:ttaubert] from comment #7)
> An easier STR is to start a normal build (non-e10s) and open an e10s window.
> If closing the e10s-window causes an error message in the console that says
> "aWindow.content is null" then sessionstore will fail too.

I think this seems to be a different problem.
Please file a separate bug.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

It's not. Please take a look at comment #1. I can tell that this is exactly what prevents sessionstore from recording closed windows as closed.

Comment 11

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: session-store-cpow

The second hunk is unrelated--I just wanted to fix a warning I was getting when the properties are undefined.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8479271 [details] [diff] [review]
session-store-cpow

Review of attachment 8479271 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, that was easier than I expected. Thanks!

Comment 13

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cfeb1314dc1

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9cfeb1314dc1