No need to call stop() in chromecast code

RESOLVED FIXED

Status

()

Firefox for Android
Screencasting
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wesj, Unassigned)

Tracking

unspecified
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8477545 [details] [diff] [review]
Patch

This already landed on nightly in a different patch (bug 1055338). Needs to go to aurora. Sorry for the mixup.
(Reporter)

Comment 1

4 years ago
Comment on attachment 8477545 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: casting
[User impact if declined]: crash when video finishes casting.
[Describe test coverage new/current, TBPL]: working on em
[Risks and why]: Low risk. stop() does nothing but call the callback passed to it. Its a stub. Passing null just makes it crash.
[String/UUID change made/needed]: none.
Attachment #8477545 - Flags: review+
Attachment #8477545 - Flags: approval-mozilla-aurora?
Attachment #8477545 - Attachment is patch: true
status-firefox33: --- → affected
status-firefox34: --- → fixed
Attachment #8477545 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox33: affected → fixed
(Reporter)

Comment 3

4 years ago
backed out for bustage (left over mirroring code):
https://hg.mozilla.org/releases/mozilla-aurora/rev/52f54e8b5414

will reland shortly.
status-firefox33: fixed → affected
(Reporter)

Updated

4 years ago
Blocks: 901803
(Reporter)

Comment 4

4 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/439ceee39acb
status-firefox33: affected → fixed
(Reporter)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.