Closed Bug 1057487 Opened 10 years ago Closed 10 years ago

No need to call stop() in chromecast code

Categories

(Firefox for Android Graveyard :: Screencasting, defect)

Product:
Firefox for Android Graveyard
Component:
Screencasting
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox33 fixed, firefox34 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: wesj, Unassigned)

References

Details

Attachments

(1 file)

Patch
1.09 KB, patch
wesj
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
This already landed on nightly in a different patch (bug 1055338). Needs to go to aurora. Sorry for the mixup.
Comment on attachment 8477545 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: casting
[User impact if declined]: crash when video finishes casting.
[Describe test coverage new/current, TBPL]: working on em
[Risks and why]: Low risk. stop() does nothing but call the callback passed to it. Its a stub. Passing null just makes it crash.
[String/UUID change made/needed]: none.
Attachment #8477545 - Flags: review+
Attachment #8477545 - Flags: approval-mozilla-aurora?
Attachment #8477545 - Attachment is patch: true
Attachment #8477545 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
backed out for bustage (left over mirroring code):
https://hg.mozilla.org/releases/mozilla-aurora/rev/52f54e8b5414

will reland shortly.
status-firefox33: fixed → affected
Blocks: 901803
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: