Update OTS to 97d043dd8977751835ca8d33d773ae8416e456d5 or later

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fredw, Assigned: fredw)

Tracking

Trunk
mozilla34
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

No description provided.
Just curious, which fix do you want this for specifically?

We need to fix cmap soon: https://github.com/khaledhosny/ots/issues/34
I saw that b2c8c01258eb706ab426fa72f53b8cacb61c22c8 changed again the way we pass info to OTSContext, so I wanted to update the Gecko code for that and also take the opportunity to add a small bash script to help keeping the code up-to-date. If there are important commits to take, I can just wait before asking a review.
Ok, I think you can do the update on the Gecko side.  If we end up needing another commit I think taking that is easy enough later.  Thanks.
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #8477831 - Flags: review?(jfkthame)
Attachment #8477831 - Flags: review?(jfkthame) → review+
Attachment #8477832 - Flags: review?(jfkthame) → review+
Comment on attachment 8477833 [details] [diff] [review]
Part 3 - Update OTS to 97d043dd8977751835ca8d33d773ae8416e456d5

Review of attachment 8477833 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUserFontSet.cpp
@@ -194,5 @@
>      gfxProxyFontEntry  *mProxy;
>  };
>  
> -/* static */ bool
> -gfxProxyFontEntry::OTSMessage(void *aUserData, const char *format, ...)

Also remove the declaration from gfxUserFontSet.h.
Attachment #8477833 - Flags: review?(jfkthame) → review+
(In reply to Behdad Esfahbod from comment #2)
> Just curious, which fix do you want this for specifically?
> 
> We need to fix cmap soon: https://github.com/khaledhosny/ots/issues/34

(In reply to Behdad Esfahbod from comment #4)
> Ok, I think you can do the update on the Gecko side.  If we end up needing
> another commit I think taking that is easy enough later.  Thanks.

OK, I'll submit a fourth patch that includes https://github.com/khaledhosny/ots/issues/34. I'll just wait that my comment on https://github.com/khaledhosny/ots/commit/080d3a89d568e029cdc0b74f19081b61af1f25d1 is addressed.
OK, here is part 4. We can take it if Jonathan is fine with the temporary "uncommenting" in gfx/ots/src/cff_type2_charstring.cc.
Attachment #8477877 - Flags: review?(jfkthame)
Comment on attachment 8477877 [details] [diff] [review]
Part 4 - Update OTS to 5c25bdac8f02080f49fa416ea997ed77e3be0d30

Review of attachment 8477877 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ots/src/cff_type2_charstring.cc
@@ +707,5 @@
>        argument_stack->pop();
>      return true;
>    }
>  
> +  //OTS_WARNING("Undefined operator: %d (0x%x)", op, op);

There are plenty of other cases where this function returns failure without generating a specific message; so omitting this one for now doesn't seem too bad.
Attachment #8477877 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #12)
> Comment on attachment 8477877 [details] [diff] [review]
> Part 4 - Update OTS to 5c25bdac8f02080f49fa416ea997ed77e3be0d30
> 
> Review of attachment 8477877 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/ots/src/cff_type2_charstring.cc
> @@ +707,5 @@
> >        argument_stack->pop();
> >      return true;
> >    }
> >  
> > +  //OTS_WARNING("Undefined operator: %d (0x%x)", op, op);
> 
> There are plenty of other cases where this function returns failure without
> generating a specific message; so omitting this one for now doesn't seem too
> bad.

Nothing is lost as far as Gecko is concerned actually, since previously OTS_WARNING wrote to the stderr and only when OTS_DEBUG was defined.
Keywords: checkin-needed
Depends on: 1074809
You need to log in before you can comment on or make changes to this bug.