1057534 - Add Grunt for some task management

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Peter deHaan [:pdehaan]]

Lets take another look at Grunt, but this time stick with grunt AND keep the makefile.

I have a branch here and I added a bunch of comments:
https://github.com/pdehaan/loop-server/commit/8ecd512c1bfcb1e640e6016b5c071c74d2f555bf

If you guys think there is enough value in checking copyrights, linting JSON, or any of the other current/potential Grunt tasks, then I can submit a PR against the loop-server repo.

This time, the makefile is mostly unchanged, apart from a few places where it calls out to the Grunt tasks. I didn't try moving all the mocha and other tasks to the Grunt file, but we can slowly move some tasks over as they make sense (ie: maybe the `make clean` task since the grunt-contrib-clean may handle cross OS things a bit better (assuming we want to support Windows and other OSes -- assuming Windows doesn't support `rm -rf` in the regular cmd.exe).

Comment 1

[Rémy Hubscher (:natim)]

Can you make a PR with these tasks:

 - grunt lint
 - grunt-copyright: Check for MPL
 - grunt-todo: We are using XXX for TODO in the source code

+1 for the package.json dependency ordering.

I am not a big fan of the JSDoc but maybe we could benefit from it.

Comment 2

[Peter deHaan [:pdehaan]]

https://github.com/mozilla-services/loop-server/pull/197

```
$ grunt lint copyright todo
Running "eslint:src" (eslint) task

Running "jsonlint:src" (jsonlint) task
>> 6 files lint free.

Running "copyright:src" (copyright) task

Running "todo:src" (todo) task

loop/routes/call-url.js

	line 40  XXX  Bug 1032966 - call_url is deprecated

loop/routes/calls.js

	line 88  XXX  Bug 1032966 - call_url is deprecated

Done, without errors.
```

Comment 3

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/72d0a5c81a83bdaeb3d07339e27e83eaf1d94c85