1057541 - Add a way to mark dictionary members as required

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This could be pretty useful for some APIs.  Note also https://www.w3.org/Bugs/Public/show_bug.cgi?id=26303

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Change the IDL parser to allow an optional "required" on dictionary members

Cameron OK'd this in principle; I'll write up a spec update on Monday

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add a way to ask an IDLArgument whether it guarantees that it will always have a value

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Change codegen to support required dictionary members

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddea90d3a95e
https://hg.mozilla.org/integration/mozilla-inbound/rev/7206acdbc055
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c54535a0c6b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ddea90d3a95e
https://hg.mozilla.org/mozilla-central/rev/7206acdbc055
https://hg.mozilla.org/mozilla-central/rev/2c54535a0c6b

Comment 6

[Richard Barnes [:rbarnes]]

Comment on attachment 8477656 [details] [diff] [review]
part 2.  Add a way to ask an IDLArgument whether it guarantees that it will always have a value

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment 7

[Boris Zbarsky [:bzbarsky]]

You this lands on aurora, bug 1070764 needs to do so as well.

Comment 8

[Richard Barnes [:rbarnes]]

(In reply to Boris Zbarsky [:bz] from comment #7)
> You this lands on aurora, bug 1070764 needs to do so as well.

I was going to do that next :)

Approval Request Comment (for all three patches)

[Feature/regressing bug #]: Required for Bug 1037892
     
[User impact if declined]: Blocks uplift of Bug 1037892 (see uplift request there for more detail)

[Describe test coverage new/current, TBPL]: N/A

[Risks and why]: Low risk, minor change to WebIDL

[String/UUID change made/needed]: none

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8477656 [details] [diff] [review]
part 2.  Add a way to ask an IDLArgument whether it guarantees that it will always have a value

Aurora+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1ee41b57b49d
https://hg.mozilla.org/releases/mozilla-aurora/rev/e4605ac1576e
https://hg.mozilla.org/releases/mozilla-aurora/rev/6b39085efdd9

I'm assuming that the missing approval on part 3 was an accidental omission :)

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8477657 [details] [diff] [review]
part 3.  Change codegen to support required dictionary members

Seems I missed marking approvals on part 1 and part 3. I had previously reviewed all of the patches so Ryan was correct. I have now cleaned up the approvals.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Added relevant documentation to https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings