1057560 - Implement WrappedJSToDictionary()

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Implement WrappedJSToDictionary(), v1

e.g.

--- Foo.webidl ---
dictionary Foo {
  DOMString bar;
  any       baz;
};

--- Foo.js ---
Services.obs.notifyObservers({bar: "BAR", baz: true}, "foo-topic");

--- Foo.cpp ---
#include "mozilla/dom/FooBinding.h"
#include "mozilla/dom/BindingUtils.h"

nsresult
FooClass::Observe(nsISupports* aSubject, const char* aTopic, const char16_t* aData)
{
  if (strcmp(aTopic, "foo-topic") == 0) {
    Foo foo;

    if (!WrappedJSToDictionary(aSubject, foo)) {
      return NS_ERROR_INVALID_ARG;
    }

    HandleFoo(foo);
  }
  return NS_OK;
}

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8477654 [details] [diff] [review]
Implement WrappedJSToDictionary(), v1

Local style is JS::Rooted<JSObject*> and JS::Rooted<JS::Value> instead of RootedObject and RootedValue.

r=me with that; sorry that took so long.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Implement WrappedJSToDictionary(), v1.1 r=bz

Use correct local style; carrying r+ forward.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/b2g-inbound/rev/35be32fbb756

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35be32fbb756