Closed Bug 1057585 Opened 10 years ago Closed 10 years ago

Disable WebAudio APIs in prerendering

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: rvid, Assigned: rvid)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

1057585.patch
2.75 KB, patch
rvid
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: prerendering
Summary: Add UnsafeInPrerendering attribute to WebAudio APIs → Disable WebAudio APIs in prerendering
-AudioBufferSourceNode.webidl - start, stop
-AudioContext.webidl - createMediaElementSource, createMediaStreamSource
-AudioDestinationNode.webidl
-OscillatorNode.webidl - start
Attached patch 1057585.patch (obsolete) — — Splinter Review 

    
  

        Attachment #8483685 -
        Flags: review?(jst)

        Attachment #8483685 -
        Flags: review?(jst) → review+

    
  
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        1057585.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8483685 -
        Attachment is obsolete: true

        Attachment #8507447 -
        Flags: review+

    
    

    
  
Hi Roshan,

Checkin needed bugs require a successful try run.

Could you provide a try results (just to make sure nothing breaks etc) maybe https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices can helpful.

Thanks!
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/aadaaf2861b1
Assignee: nobody → roshanvid
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: