Closed Bug 1057601 Opened 6 years ago Closed 6 years ago

Use UncheckedUnwrap in CPOW code

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

I originally used CheckedUnwrap in the CPOW code because it seemed safer. However, I now see that this was a mistake. We store CPOWs unwrapped in the various tables. Now that we have bug 1052093, the CPOW code in the parent process always operates in the unprivileged junk scope. As a consequence, unwrapping of CPOWs to get them out of tables is going to go through security wrappers and CheckedUnwrap fails.
Attachment #8477705 - Flags: review?(mrbkap)
Attachment #8477705 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/184bbe9eacf4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.