1057604 - [KK][Download Manager] The "Save" button is present but nonfunctional when downloading .amr audio files

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Seth Miko [:SMiko]]

Attachment: amr.txt

Description:
After downloading a audio file with AMR-NB format, the save button is displayed but does not function. 

Repro Steps:
1) Set the base to 165
2) Update a Flame to 20140821030000
3) Open Browser and navigate to http://samples.mplayerhq.hu/A-codecs/amr/sample.amr

Actual:
Opening the downloaded file displays the "Save" button, which is non functional.

Expected:
The "save" button is functional or not displayed as the file is automatically saved when downloaded.

Flame 2.0(319mb/165 base)

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140821030000
Gaia: 06edd086387c2150017b549e6318a61cd7e4fd02
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0)
Firmware Version: 
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 100%

See attached: logcat

Video clip: http://youtu.be/b-1QmiuLMf0

Comment 1

[Seth Miko [:SMiko]]

This issue DOES repro on Flame 2.1(319mb/123 base), Open C 2.1 (123 base), Flame 2.0(319mb/123 base), and Open C 2.0 (123 base)

Acutal Result:Opening the downloaded file displays the "Save" button, which is non functional.
 
Flame 2.1 (319mb/123 base)

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140822040202
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1 (123 base)

Environmental Variables:
Device: Open_C Master
Build ID: 20140822040202
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 (319mb/123 base)

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140822000206
Gaia: 64b0c0ae60fdeac953a7e2a3c368d124bf848477
Gecko: 5075528d7241
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open C 2.0 (319mb/ 123 base)

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140822000206
Gaia: 64b0c0ae60fdeac953a7e2a3c368d124bf848477
Gecko: 5075528d7241
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Does this reproduce on 1.4?

Comment 3

[Seth Miko [:SMiko]]

This issue does NOT repro on Flame 1.4 (319mb/123 base)

Flame 1.4(319mb/123 base)

Environmental Variables:
Device: Flame 1.4 (319mb)
Build ID: 20140825063013
Gaia: cf9d74da6653efeb43d9653e81c61aa00e693a67
Gecko: cdcb73d0febc
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 4

[Seth Miko [:SMiko]]

Attachment: Flame 1.4 (319mb/123 base) Actual result: Save button is not present

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 1.4. The save button should be removed or it should function properly. We should not present the user with a save button that is non-fuctional so nominating this 2.0?

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue no longer occurs on the latest 2.1 nightly and tinderbox builds.  However it does still reproduce in the latest nightly 2.0 build.  Per instructions I will be looking for the window where this issue was fixed.

Environmental Variables:
Device: Flame Master Nightly
BuildID: 20140826040204
Gaia: 4d1d0ea5a82cddeeab497774cfa1703639e3c7d9
Gecko: dc352a7bf234
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame Master Tinderbox
BuildID: 20140826125726
Gaia: ea93363a8c424d65a9ad91438ce6961377a20f98
Gecko: f9bfe115fee5
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Environmental Variables:
Device: Flame 2.0 Nightly
BuildID: 20140826000204
Gaia: a51633e29a7826b6bf07cb1c5ad81b3217b9820a
Gecko: fdac649a65ac
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 7

[bhavana bajaj [:bajaj]]

Blocking given we have a non-functional button and this is a regression.

Comment 8

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1015247 seems like a very good candidate for where this issue was fixed in Central Flame.

B2g-inbound Regression Window

Last Broken 
Environmental Variables:
Device: Flame Master
BuildID: 20140822011653
Gaia: de6d327b2c2854f1fcedd87dfca9cbbec3e63c43
Gecko: 5a52cff82be1
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Working 
Environmental Variables:
Device: Flame Master
BuildID: 20140822024656
Gaia: e9e0c2ea86cf51a5107bcb54699735e0dbb701c4
Gecko: 83c5a9e63108
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Last Broken gaia / First Working gecko - Issue is NOT fixed
Gaia: de6d327b2c2854f1fcedd87dfca9cbbec3e63c43
Gecko: 5a52cff82be1

First Working gaia / Last Broken gecko - Issue IS fixed
Gaia: de6d327b2c2854f1fcedd87dfca9cbbec3e63c43
Gecko: 5a52cff82be1

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/de6d327b2c2854f1fcedd87dfca9cbbec3e63c43...e9e0c2ea86cf51a5107bcb54699735e0dbb701c4

Comment 9

[Joshua Mitchell (Inactive)]

Wilson - this bug started off in 2.0 and 2.1 but stopped reproing in 2.1 so the above window was to find out what fixed it in 2.1

Bug 1015247 seems to be what fixed it, so can that patch be uplifted to 2.0 to fix this issue there?

Comment 10

[Wilson Page [:wilsonpage]]

I'm afraid we can't uplift as it uses new web-component technologies that will be less stable in 2.0 Gecko. It would be simpler, and less risky to custom fix it on v2.0 branch.

Comment 11

[:gerard-majax]

Reproduced on current 2.0, logcat shows:

> 09-01 15:20:28.606 12349 12349 E GeckoConsole: [JavaScript Error: "TypeError: storage is undefined" {file: "app://music.gaiamobile.org/gaia_build_open.js" line: 193}]

Comment 12

[:gerard-majax]

Let's see if I can do something :)

Comment 13

[:gerard-majax]

Bug 1015247 contains this change on open.js which completely disables the save button https://github.com/mozilla-b2g/gaia/pull/19833/files#diff-21

Comment 14

[:gerard-majax]

So on master, the save button is just not displayed at all.

Comment 15

[:gerard-majax]

On 2.0, the saveButton does have its hidden attribute to true, but it's still displayed ...

Comment 16

[:gerard-majax]

Attachment: Gaia PR against v2.0 branch

Dominic, this simple CSS changes fixes the issue.

Comment 18

[Dominic Kuo [:dkuo]]

Comment on attachment 8482303 [details] [review]
Gaia PR against v2.0 branch

Thanks Alexandre, looks good to me!

Comment 19

[:gerard-majax]

(In reply to Dominic Kuo [:dkuo] from comment #18)
> Comment on attachment 8482303 [details] [review]
> Gaia PR against v2.0 branch
> 
> Thanks Alexandre, looks good to me!

Thanks. For some reason, the try link on the PR is broken, I'll have to force a retrigger to make sure :(

Comment 20

[:gerard-majax]

New Gaia-Try: https://tbpl.mozilla.org/?rev=18befca5a18755e9ce306fff3e08aaf784fd8a50&tree=Gaia-Try

Comment 21

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #20)
> New Gaia-Try:
> https://tbpl.mozilla.org/
> ?rev=18befca5a18755e9ce306fff3e08aaf784fd8a50&tree=Gaia-Try

So it's green with unrelated failures?

Comment 22

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/d056733f8a7a1a152f5458b323f092c47dbffa48

Comment 23

[Ryan VanderMeulen [:RyanVM]]

This shouldn't have landed on v2.0 without approval first. Due to recent policy changes, all B2G uplifts needs approval now regardless of blocking status. Please request v2.0 approval on this patch or backout ASAP. Sorry for the inconvenience.

Comment 24

[:gerard-majax]

Okay, sorry, I was not aware of yet another change that forces requesting approval regardless the blocking status.

Comment 25

[:gerard-majax]

Comment on attachment 8482303 [details] [review]
Gaia PR against v2.0 branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: broken feature, save does not work
[Testing completed]: on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 26

[William Hsu [:whsu]]

Thanks everyone.
Verified it. The "Save" button has been removed.
Attach the screenshot. (2014-09-16-02-16-13.png)

* Build Information:
 - Gaia        7edd3b0b9f65c3dde235c732d270e43e055a1254
 - Gecko       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
 - BuildID     20140914162307
 - Version     32.0
 - Base image  Flame KK
 - ro.build.version.incremental=27
 - ro.build.date=Thu Sep  4 14:59:02 CST 2014