1057612 - Tell Apple AAC decoder about seeks.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Ralph Giles (:rillian)]

Attachment: Signal discontinuities to the AudioFileStreamParseBytes

According to docs, where supposed to flag input discontinuities to AudioFileStreamParseBytes(). Set a flag on flush and use it to add the appropriate value the next time SubmitSample runs.

In theory this races since ::Flush and ::SubmitSample run out of different TaskQueues, but we've just flushed mTaskQueue when we set it, so the change should be seen correctly.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8477718 [details] [diff] [review]
Signal discontinuities to the AudioFileStreamParseBytes

Review of attachment 8477718 [details] [diff] [review]:
-----------------------------------------------------------------

I think for thread safety, you should actually put a task onto the queue that sets mFlushed to true on the task queue, rather than setting it on the decode task queue thread and hoping there's a memory barrier in between setting it and it next being read on the other task queue thread when it's used. There probably will be a memory barrier, but I think it's best to be careful. You could also make it atomic.

Comment 3

[Ralph Giles (:rillian)]

Attachment: Signal discontinuities to the AudioFileStreamParseBytes

Dispatch a task to update mFlushed to avoid thread safety concerns.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8477747 [details] [diff] [review]
Signal discontinuities to the AudioFileStreamParseBytes

Review of attachment 8477747 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6478460e5dd0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6478460e5dd0