Closed Bug 1057612 Opened 5 years ago Closed 5 years ago

Tell Apple AAC decoder about seeks.

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
According to docs, where supposed to flag input discontinuities to AudioFileStreamParseBytes(). Set a flag on flush and use it to add the appropriate value the next time SubmitSample runs.

In theory this races since ::Flush and ::SubmitSample run out of different TaskQueues, but we've just flushed mTaskQueue when we set it, so the change should be seen correctly.
Assignee: nobody → giles
Attachment #8477718 - Flags: review?(cpearce)
Comment on attachment 8477718 [details] [diff] [review]
Signal discontinuities to the AudioFileStreamParseBytes

Review of attachment 8477718 [details] [diff] [review]:
-----------------------------------------------------------------

I think for thread safety, you should actually put a task onto the queue that sets mFlushed to true on the task queue, rather than setting it on the decode task queue thread and hoping there's a memory barrier in between setting it and it next being read on the other task queue thread when it's used. There probably will be a memory barrier, but I think it's best to be careful. You could also make it atomic.
Attachment #8477718 - Flags: review?(cpearce) → review-
Dispatch a task to update mFlushed to avoid thread safety concerns.
Attachment #8477718 - Attachment is obsolete: true
Attachment #8477747 - Flags: review?(cpearce)
Comment on attachment 8477747 [details] [diff] [review]
Signal discontinuities to the AudioFileStreamParseBytes

Review of attachment 8477747 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8477747 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/6478460e5dd0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.