Closed Bug 1057654 Opened 10 years ago Closed 8 years ago

Investigate why using the "Forget About This Site" context menu item in the Library refocuses the browser the first time you use it (Windows-only?)

Categories

(Firefox :: Bookmarks & History, defect)

31 Branch
defect
Not set
normal
Points:
3

Tracking

()

RESOLVED FIXED

People

(Reporter: themailmanagain, Unassigned)

References

Details

(Keywords: papercut, regression)

Attachments

(1 file)

Attached image ForgetHistoryBug.gif
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

Every time i select a Site Entry - a site i visited listed in the History ( Library ) window - to make Firefox forget about it by Right Clicking on this Entry and Clicking "Forget About This Site"; the Site Entry is indeed deleted as expected but soon after, the History ( Library ) window looses focus and the Main Firefox windows come back in front of it ( the History ( Library ) window.).

PS1. I saved a GIF Animation of the behavior described bellow, for those that prefer visuals rather than text; just save the attached gif file to your computer and drag it into your browser window ;)

PS2. A you will see on the animation, at first it seems i Alt + Tab out of the History ( Library ) window, i did no such thing, this is the Bug's doing. I did Alt + Tab back, after thats not the Bug.

PS3. Usually i manually delete sites from the history, directly from the History ( Library ) window instead of deleting sites using the Clear All History window ( Accessible by pressing Shift + Ctrl + Delete ) this led me to notice a very annoying behavior ( which is why i am reporting this since it's probably a bug ).


Actual results:

At this point i have the Main Firefox window in focus and the History ( Library ) window on the background. I know i can simply Alt + Tab back to the History ( Library ) window, but since this behavior only happens on the VERY FIRST time i use the "Forget About This Site" option, it seems to me it's more of a Bug rather than a Feature of Firefox.

Meaning, the first time in a Firefox Session that i use the "Forget About This Site" option, the History ( Library ) windows, looses focus. I Alt + Tab back to it, select any other Site entry to "forget", and as soon as i click "Forget About This Site" the site is deleted and i remain in the History ( Library ) window.

It then, DOES NOT loose focus from the Second time i use the "Forget About This Site" option onwards.

Meaning that, i think this is a Bug, since only on the first time i use the function in a Firefox Session the focus on the History ( Library ) window is lost.


Expected results:

If this behavior were to be considered a Feature ( A Firefox Default behavior ) i suppose that every time i clicked "Forget About This Site", the History ( Library ) window should loose focus and the way it is right now, focus is lost only the first time i use the option. Or inversely, every time i clicked "Forget About This Site", the History ( Library ) window should NEVER loose focus, and the way it is right now, focus is lost only the first time i use the option. Never from the second time i use the option, onwards.
Summary: Using the "Forget About This Site" in the History ( Library ) window, makes the History ( Library ) windows loose focus. → Using the "Forget About This Site" in the History ( Library ) window, makes the History ( Library ) window loose focus.
Component: Untriaged → Places
Product: Firefox → Toolkit
Summary: Using the "Forget About This Site" in the History ( Library ) window, makes the History ( Library ) window loose focus. → Using the "Forget About This Site" in the History ( Library ) window, makes the History ( Library ) window lose focus.
Component: Places → Bookmarks & History
Product: Toolkit → Firefox
OS: Windows 7 → All
Hardware: x86_64 → All
Since i don't know how to edit the main bug description i'll just add this note here.

Everywhere you read the word "loose" disregard it and istead read it as the word "lose".

;)
Since i don't know how to edit the main bug description i'll just add this note here.

Everywhere you read the word "loose" disregard it and instead read it as the word "lose".

;)
Component: Bookmarks & History → Places
Product: Firefox → Toolkit
Status: UNCONFIRMED → NEW
Component: Places → Bookmarks & History
Ever confirmed: true
Keywords: papercut
Product: Toolkit → Firefox
FWIW, I can reproduce this on Windows, but not on OS X. There's nothing in the code that explicitly tries to switch focus, as far as I can tell... so I'm not sure what's going on here. :-\
Points: --- → 3
Flags: firefox-backlog+
Summary: Using the "Forget About This Site" in the History ( Library ) window, makes the History ( Library ) window lose focus. → Investigate why using the "Forget About This Site" context menu item in the Library refocuses the browser the first time you use it (Windows-only?)
Flags: qe-verify?
i just tested it with no extensions or plugins enabled, same problem.

i've also created a new profile, and disabled extensions and or plugins that may have been enabled in the new profile - which were none - still the same problem.

maybe someone could try it on different windows versions. 32 bit systems ?!

i've known this bug for a while, maybe more than a year?!

i just never bothered file a bug report because i thought: "come on! someone knows about this already!"
or even "who cares about it?! with millions of other bugs around, who will give a rat's rear end about this ?!"

;) so here we are...

:\
(In reply to MailMan from comment #4)
> i just tested it with no extensions or plugins enabled, same problem.
> 
> i've also created a new profile, and disabled extensions and or plugins that
> may have been enabled in the new profile - which were none - still the same
> problem.
> 
> maybe someone could try it on different windows versions. 32 bit systems ?!

No no, I could reproduce, it's just a bug. :-(


> i've known this bug for a while, maybe more than a year?!

Do you know if it ever worked correctly? If so, could you try running mozregression ( http://mozilla.github.io/mozregression/ ) to figure out exactly when it broke? That'd be pretty helpful, because when I looked at the code it wasn't really obvious to me why it's breaking...

> i just never bothered file a bug report because i thought: "come on! someone
> knows about this already!"
> or even "who cares about it?! with millions of other bugs around, who will
> give a rat's rear end about this ?!"
> 
> ;) so here we are...
> 
> :\

We have a proverb at Mozilla: "If you see something, file something". ;-)
Regression window(m-i)
Goo:
http://hg.mozilla.org/mozilla-central/rev/db3e06f7018e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110208 Firefox/4.0b12pre ID:20110208133732
Bad:
http://hg.mozilla.org/mozilla-central/rev/37094ed97c9e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110208 Firefox/4.0b12pre ID:20110208142057
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=db3e06f7018e&tochange=37094ed97c9e

Triggered by: 
2ff5b8624463	Dan Witte — Bug 625497 - Clear Adobe Flash Cookies (LSOs) when "Forget This Site" is selected. r=ehsan, a=final+
Blocks: 625497
Keywords: regression
forget about this site starts up any plug-in that might store LSO data, and those might cause a focus change, Flash might do. Might be related to bug 768802 and maybe fixed by the same patch (or fixed by Flash 15 beta)
nd that can also explain why you cannot reproduce on OS X, like bug 768802
Now that bug 768802 is fixed, this might be fixed on latest aurora ( https://aurora.mozilla.org/ )? Unless this is also affected by bug 1063978...
GOOD NEWS !!!

I am still running Firefox 31 on Windows 7 x64

I Just updated to Flash 15.0.0.152 and it seems to have solved the problem.

I can no longer reproduce the bug.

;)
Fixed by bug 768802, some time ago.
Status: NEW → RESOLVED
Closed: 8 years ago
Depends on: 768802
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: