1057666 - No line break on structured logging failure messages with tbplformatter

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Comment 1

[Ahmed Kachkach [:akachkach]]

Submitted this a bit too soon :)

So, I'm filing this because this run has weird formatting for errors:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46605945&tree=Try&full=1#error0

Failures do not have a line break at the end, which causes the following messages to be appended at the end of the line. There's a scenario where this seems possible in the code (when the "expected" field == "PASS") but it doesn't seem to be the case here.

Comment 2

[James Graham [:jgraham]]

Attachment: Ensure that only one log message is printed per line, r=chmanchester

Comment 3

[James Graham [:jgraham]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1be1fd7ca9e4

Comment 4

[Ahmed Kachkach [:akachkach]]

Comment on attachment 8477842 [details] [diff] [review]
Ensure that only one log message is printed per line, r=chmanchester

Review of attachment 8477842 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozlog/mozlog/structured/formatters/tbplformatter.py
@@ +70,5 @@
>          message = "- " + data["message"] if "message" in data else ""
>          if "stack" in data:
>              message += "\n%s" % data["stack"]
> +        if message and message[-1] == "\n":
> +            message = message[:-1]

Maybe we could use "message = message.rstrip('\n')" ?

Comment 5

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0fdf7c9a10

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb0fdf7c9a10