Closed Bug 1057670 Opened 7 years ago Closed 7 years ago

Change title displayed in collapsed rocketbar within apps

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: daleharvey, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
benfrancis
: review+
Details | Review
No description provided.
Not assigned, and ridiculously easy - mind if I steal it?
Status: NEW → ASSIGNED
Attached file Github pull request
Course, was just filing for book keeping
Assignee: nobody → kgrandon
Comment on attachment 8478546 [details] [review]
Github pull request

Added a test in case we may want to shuffle this stuff around in the future. Could either of you guys take a look? Thanks!
Attachment #8478546 - Flags: review?(dale)
Attachment #8478546 - Flags: review?(bfrancis)
Comment on attachment 8478546 [details] [review]
Github pull request

I think we're overloading the _gotName property in AppChrome, this property should only be set if we've actually checked there is a name in the manifest or a namechange event has been received.

Maybe we can move the code that checks this further up so you don't need to do it here? Perhaps that's what you were talking about in your previous review of my patch?

r+me with that fixed.
Attachment #8478546 - Flags: review?(bfrancis) → review+
Comment on attachment 8478546 [details] [review]
Github pull request

Yeah, I agree that the title thing is a mess and needs refactoring. We have a bunch of tests now, so it's not so bad.
Attachment #8478546 - Flags: review?(dale)
Master: https://github.com/mozilla-b2g/gaia/commit/93ed9b4353ade52f9c6e0959922efced1fb21c26
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.