Closed Bug 1057670 Opened 7 years ago Closed 7 years ago
Change title displayed in collapsed rocketbar within apps
No description provided.
As specified in https://mozilla.app.box.com/s/2ujr31jyn3z58bowj2jd
Not assigned, and ridiculously easy - mind if I steal it?
Status: NEW → ASSIGNED
Course, was just filing for book keeping
Assignee: nobody → kgrandon
Comment on attachment 8478546 [details] [review] Github pull request Added a test in case we may want to shuffle this stuff around in the future. Could either of you guys take a look? Thanks!
Comment on attachment 8478546 [details] [review] Github pull request I think we're overloading the _gotName property in AppChrome, this property should only be set if we've actually checked there is a name in the manifest or a namechange event has been received. Maybe we can move the code that checks this further up so you don't need to do it here? Perhaps that's what you were talking about in your previous review of my patch? r+me with that fixed.
Attachment #8478546 - Flags: review?(bfrancis) → review+
Comment on attachment 8478546 [details] [review] Github pull request Yeah, I agree that the title thing is a mess and needs refactoring. We have a bunch of tests now, so it's not so bad.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.