Check for null channel in nsXPInstallManager::OnProgress

VERIFIED FIXED

Status

VERIFIED FIXED
17 years ago
3 years ago

People

(Reporter: dprice, Assigned: dprice)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
We're getting a null channel in nsXPInstallManager::OnProgress  
Check for it and return failure instead of crashing.
(Assignee)

Comment 1

17 years ago
Created attachment 54326 [details] [diff] [review]
a fix
(Assignee)

Comment 2

17 years ago
dan, can I get an r=?
sure, r=dveditz, but why is the channel null in the first place, something that
time and again the networking guys insist is impossible.
(Assignee)

Comment 4

17 years ago
I'm marking this as a dependant of 104761.  The networking guys are working on
the problem from their end.  According to darin's comment in the bug...

>------- Additional Comments From darin@netscape.com 2001-10-22 12:44 -------
>ok, so the file channel is letting file transport requests slip out... bad file
>channel!  should be an easy fix.
Depends on: 104761
(Assignee)

Comment 5

17 years ago
mscott can I get an sr= for this?

Thanks

Comment 6

17 years ago
Comment on attachment 54326 [details] [diff] [review]
a fix

sr=mscott

In the future, please follow the reviewers guideline and email me directly when
you want a review instead of cc'ing me on the bug. Thanks.
Attachment #54326 - Flags: superreview+
(Assignee)

Comment 7

17 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Checked in on 11/19/01 as dprice specifies.  Low level stuff.  Marking Verified.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.