1057866 - crash in java.lang.NullPointerException: at org.mozilla.gecko.ChromeCast.verifySession(ChromeCast.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-9c5276d4-aef8-4246-9fd9-406a52140823.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.ChromeCast.verifySession(ChromeCast.java:230)
	at org.mozilla.gecko.ChromeCast.end(ChromeCast.java:283)
	at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:166)
	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2303)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:363)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Sometimes callback is null. But I also refactored this a bit to simplify some redundant code.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8478370 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: chromecast
[User impact if declined]: crash
[Describe test coverage new/current, TBPL]: wip
[Risks and why]: Low risk. Just null checks the callback.
[String/UUID change made/needed]: none

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/7f82db190a84

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f82db190a84

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/46c3498c3bcd