Closed
Bug 1057871
Opened 10 years ago
Closed 10 years ago
Make mozconfig errors print the path to the mozconfig in use
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: jdm, Assigned: Six, Mentored)
Details
(Whiteboard: [lang=py])
Attachments
(1 file, 2 obsolete files)
1.57 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
When mach tells me that my mozconfig didn't execute correctly, it would be really useful to print out the full path to the file being executed.
Reporter | ||
Comment 1•10 years ago
|
||
Relevant code: the MozconfigLoadException in read_mozconfig in http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozconfig.py
Whiteboard: [lang=py]
Assignee | ||
Comment 2•10 years ago
|
||
Hello, Is this the behaviour you want? It only prints the full path of the mozconfig file used if there is an error in it.
Reporter | ||
Comment 3•10 years ago
|
||
That looks good to me, but gps should probably review the change. Could you give an example of the output when there's a mozconfig error?
Assignee | ||
Comment 4•10 years ago
|
||
Hi, ok i will change the reviewer. Here is the output: MozconfigLoadException: Using /home/six/mozilla-central/.mozconfig: Evaluation of your mozconfig exited with an error. This could be triggered by a command inside your mozconfig failing. Please change your mozconfig to not error and/or to catch errors in executed commands. Maybe we could change how it's displayed to highlight the file used.
Assignee | ||
Updated•10 years ago
|
Attachment #8480856 -
Flags: review?(josh) → review?(gps)
Reporter | ||
Comment 5•10 years ago
|
||
I would be tempted to use 'Evaluation of %s exited with an error' in this case.
Assignee | ||
Comment 6•10 years ago
|
||
New version taking car of josh comment
Attachment #8480856 -
Attachment is obsolete: true
Attachment #8480856 -
Flags: review?(gps)
Attachment #8481321 -
Flags: review?(gps)
Comment 7•10 years ago
|
||
Comment on attachment 8481321 [details] [diff] [review] mach_print_mozconfig_file.patch Review of attachment 8481321 [details] [diff] [review]: ----------------------------------------------------------------- We already pass the mozconfig path to the created MozconfigLoadException. I'd prefer to fix this bug by ensuring that whatever is printing the MozconfigLoadException is printing the path name, similar to what's happening at https://hg.mozilla.org/mozilla-central/file/5e9826980be5/python/mozbuild/mozbuild/base.py#l590. What mach command isn't print the mozconfig path?
Attachment #8481321 -
Flags: review?(gps)
Assignee | ||
Comment 8•10 years ago
|
||
Hi, This happens using './mach configure' if there is an error in the mozconfig used. actually the error is here: https://hg.mozilla.org/mozilla-central/file/5e9826980be5/python/mozbuild/mozbuild/base.py#l560 it comes from the fact that this "try" block doesn't catch MozconfigLoadException's
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8481321 -
Attachment is obsolete: true
Attachment #8483687 -
Flags: review?(gps)
Assignee | ||
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Updated•10 years ago
|
Attachment #8483687 -
Flags: review?(gps) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfdcf950e403
Keywords: checkin-needed
Comment 11•10 years ago
|
||
I found that the bug number in the commit message is incorrect. It's 105871 instead of 1057871.
Comment 12•10 years ago
|
||
(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #11) > I found that the bug number in the commit message is incorrect. It's 105871 > instead of 1057871. no problem, backedout the comment with the wrong bugnumber and re-checked in the correct commit message in https://hg.mozilla.org/integration/mozilla-inbound/rev/64300da7c9c4
Assignee | ||
Comment 13•10 years ago
|
||
Thanks TYLin for pointing out my typo and Tomcat for fixing it :)
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/64300da7c9c4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•