Closed Bug 1057891 Opened 5 years ago Closed 5 years ago

[EME] Resolve EME promises with void rather than undefined

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As per https://www.w3.org/Bugs/Public/show_bug.cgi?id=26457 we should resolve EME promises with void, not undefined.
Blocks: EME, 1032660
It's the same thing.  The behavior is to resolve the promise with the JS undefined value.  The name for that value's type in IDL is "void".
Ah. So we can remove the "// void, not any: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26457" comments in MediaKeySession.webidl then?
Yes, I believe so.  Those comments were marking me introducing a known deviation from the spec, with a link to the spec bug I filed in the process to get the spec to match my IDL.
Now that Bug 26457 is resolved, we can remove those comments.
Attached patch PatchSplinter Review
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8505866 - Flags: review?(bzbarsky)
Comment on attachment 8505866 [details] [diff] [review]
Patch

r=me
Attachment #8505866 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/1c3062cfe741
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Mass update firefox-status to track EME uplift.
You need to log in before you can comment on or make changes to this bug.