Closed
Bug 1057891
Opened 9 years ago
Closed 9 years ago
[EME] Resolve EME promises with void rather than undefined
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.31 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
As per https://www.w3.org/Bugs/Public/show_bug.cgi?id=26457 we should resolve EME promises with void, not undefined.
![]() |
||
Comment 1•9 years ago
|
||
It's the same thing. The behavior is to resolve the promise with the JS undefined value. The name for that value's type in IDL is "void".
Assignee | ||
Comment 2•9 years ago
|
||
Ah. So we can remove the "// void, not any: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26457" comments in MediaKeySession.webidl then?
![]() |
||
Comment 3•9 years ago
|
||
Yes, I believe so. Those comments were marking me introducing a known deviation from the spec, with a link to the spec bug I filed in the process to get the spec to match my IDL.
Assignee | ||
Comment 5•9 years ago
|
||
![]() |
||
Comment 6•9 years ago
|
||
Comment on attachment 8505866 [details] [diff] [review] Patch r=me
Attachment #8505866 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c3062cfe741
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c3062cfe741
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 9•9 years ago
|
||
Mass update firefox-status to track EME uplift.
You need to log in
before you can comment on or make changes to this bug.
Description
•