Closed Bug 1057914 Opened 7 years ago Closed 7 years ago

Remove enumeration methods from nsICommandParams

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Keywords: addon-compat)

Attachments

(2 files)

The enumeration methods in nsCommandParams are really dodgy -- they hold raw pointers into the hash table's entry store and assume that the table doesn't get resized. (I hit other problems in this code in bug 1050036; it doesn't seem to be high-quality code.)

I'd like to just remove these methods. Hopefully this is ok. It'll help with bug 1057912.
Because I'm tired of my eyes bleeding all over my keyboard every time I look at
this file.
Attachment #8478061 - Flags: review?(ehsan)
Depends on: 1057928
No longer depends on: 1057928
Keywords: addon-compat
Attachment #8478060 - Flags: review?(ehsan) → review+
Comment on attachment 8478061 [details] [diff] [review]
(part 2) - Fix the style of nsCommandParams.{h,cpp}

Review of attachment 8478061 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't really review this...
Attachment #8478061 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/01d9658ee977
https://hg.mozilla.org/mozilla-central/rev/b91deae84856
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.