1057916 - breakdown: Add FxA authentication tests

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

We have no testing infrastructure in place for FxA authentication tests with sync.  This is becoming a relatively serious risk - manual testing of all edge-cases is hard and the code is complex - any change we make to browserid_identity.js risks breaking sync in subtle edge-cases.

The main reason is that we don't have tests is that we don't have implementations of the various servers in-tree that we can use.  We can *probably* get away with mocked servers, but this isn't clear, and even if it was, would be non-trivial - so I'm marking this as a breakdown bug to get some idea of what is involved.

Comment 1

[Chris Karlof [:ckarlof]]

Related: we recently added some functional tests (primarily for regression testing sync login) for about:accounts in our FxA server. We ran into some roadblocks that make these less effective than they could be, e.g., when you log out of sync all our custom prefs set at the beginning of the test get reset.

Comment 2

[Chris Karlof [:ckarlof]]

Link to the tests mentioned above: https://github.com/mozilla/fxa-content-server/pull/1576