1057919 - [MMS][SMS] The recipient is set, when I forward message in the thread that have the draft.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[hikawashima]

Attachment: Recipient-is-not-set-in-forward-display.patch

Build ID:20140822093752
Platform Version:34.0a.1
Git Commit Info:2014-08-22 00:08:29 af4497b5

Steps to reproduce:
1.Create a thread that has been saved received messages and draft message.
  (Save a draft in the thread which have receiving message)
2.Enter this thread.
3.Tap received message and display menu
4.Select the forward.

Actual results:
Thread's recipient is set in forward display.

Expected results:
 Recipient is not set in forward display.

Please confirm a patch that I attached.

Comment 1

[hikawashima]

Comment on attachment 8478064 [details] [diff] [review]
Recipient-is-not-set-in-forward-display.patch

I will register in the pull request.
Please wait.

Comment 2

[Steve Chung [:steveck]]

Sorry but I could not reproduce what you said... :/ Ni? QA here.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I was able to reproduce this issue on the latest 2.1 Flame build using the following steps.

Repro Steps:
1) Update a Flame to 20140828040749 on two devices
2) Have Device A send an SMS to Device B
3) On Device B create a draft in the thread with the recieved message
4) On Device B reeneter the thread from step 3 and long press the recieved message.
5) Select Forward


Actual:
The forwarded message will have Device B's number in the to field by default.


Expected:
A forwarded message has no default number.

Environmental Variables:
Device: Flame Master
BuildID: 20140828040749
Gaia: 39cad6c82122b964f12a66771bfbcc14fb342d9e
Gecko: 2a15dc07ddaa
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 4

[Joshua Mitchell (Inactive)]

QA-Wanted for branch checks.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue DOES occur on 2.0 Flame, 1.4 Flame, and 2.1 OpenC.
The forwarded message has the number that it was received from in the To Field by default.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140828000650
Gaia: a6fc290a5601183f84ee9c7cb37eeebc933af2f5
Gecko: 625dd5529548
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4
BuildID: 20140827090228
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: baf01c5965ef
Version: 30.0 (1.4) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Open_C Master
BuildID: 20140828040749
Gaia: 39cad6c82122b964f12a66771bfbcc14fb342d9e
Gecko: 2a15dc07ddaa
Version: 34.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 6

[Joshua Mitchell (Inactive)]

QA-Wanted triage analysis:  Would not block on this, it is not a regression and has a bit of an unusual user-flow to it, low visibility.

Comment 7

[hikawashima]

Attachment: pull request URL

I attached pull request URL.
Please review it.

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8484910 [details] [review]
pull request URL

Sorry, I misunderstood the description you said and now I see the problem. I left my thought on github, and please request review again when you are ready, thanks!

Comment 9

[Oleg Zasypkin [:azasypkin]]

Can't reproduce the issue on the latest master and v2.2 anymore.

Please reopen if you still see this issue.