1057953 - Don't hardcode app counts in collection names

Status: RESOLVED INVALID

(Marketplace Graveyard :: Consumer Pages, defect, P5)

Description

[krupa raj[:krupa]]

Right now, we have collections like "Top 5 Community Collections". However, there is no guarantee that all 5 apps in that collection show up due to device/region restrictions. For example, that collection has only 4 apps in China.

We should not be hard coding app counts in collection names

Comment 1

[Chuck Harmston [:chuck]]

Sending to Scott, as this isn't something the code should do (given complex pluralization rules in some languages). We'll need to avoid using numbers in collection titles.

Comment 2

[sdevaney]

Ah! Good call-out. I think it should be simple enough to adjust to "Top Community Picks" or something more numerically generic. However, I'll need to run this title change by localization (I'm not sure if simply removing the "5" from the title will be a proper fix).

Comment 3

[Chuck Harmston [:chuck]]

Do you have what you need for launch tomorrow, Scott?

Comment 4

[sdevaney]

Yeah we're good for launch. I specifically chose five apps that are valid in all of our current FxOS markets for the debut of this collection. I can adjust the title moving forward so we don't get stuck at some point with a "Top 5" collection that is anything but. Thanks!

Comment 5

[Kevin Ngo [:ngoke]]

Filtering can have unexpected changes (region + device + app status + developer delisting). There's no harm in changing it to Top X Apps. Though you're still free to try to keep at 5.