Closed Bug 1058084 Opened 6 years ago Closed 6 years ago

Micro-optimize InlineList insertion and removal

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(1 file)

The attached patch micro-optimizes InlineList insertion and removal by helping the compiler avoid redundant loads. For example, in remove, the compiler previously had to load t->next twice, because it can't prove that the intervening store to t->prev->next doesn't alias t->next.
Attachment #8478348 - Flags: review?(jdemooij)
Comment on attachment 8478348 [details] [diff] [review]
micro-inlinelist.patch

Review of attachment 8478348 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8478348 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/dbd56f218adc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.