1058088 - [NFC] Add a developer setting to enable NFC debug

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

In Settings > Developer debug section we would like to add a "NFC output in ADB" checkbox which should trigger enabling NFC debug in Gaia System app. 

This is a result of the discussion in Bug 1055446 and is needed by QA to quickly identify problems with NFC.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Hello Arthur, could you advise how this can be done properly? 

I've added new li element in apps/settings/elements/developer.html with name 'nfc.debugging.enabled' and used SettingsListner.observe('nfc.debugging.enabled', ...) in NfcManager. After make-reset gaia the screen was stuck on 'based on mozilla technology'. Am I missing something here?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Any javascript error? May I check your patch?

p.s. Maybe it is simply a typo. It should be "SettingsListener". "e" is missing in your script.

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Thanks Arthur, it was a typo ;). Once I have the full patch I'll upload it for review.

Comment 4

[Francesco Lodolo [:flod]]

Please don't forget to test your patch with pseudo-locales, more info here
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Gaia

Hint: the current patch has issues

Comment 5

[Krzysztof Mioduszewski[:tauzen]]

Thanks for the heads up. I assume it's enough to add the new string to en-US.properties since the pseudo-locales test is successful.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Krzysztof Mioduszewski[:kmioduszewski][:tauzen] from comment #5)
> Thanks for the heads up. I assume it's enough to add the new string to
> en-US.properties since the pseudo-locales test is successful.

Yes, en-US.properties is enough, don't bother about other locales in Git (they'll be removed soon).

Comment 7

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1058088.txt

Hello Arthur, could you review this? 

This patch adds new Developer "NFC output in ADB" setting. Both NfcManager and NfcHandoverManager observe this setting and set DEBUG flag accordingly.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8480108 [details] [review]
pull-request-1058088.txt

r=me for the settings part with the comment addressed. Flag Alive for the system part.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8480108 [details] [review]
pull-request-1058088.txt

Don't you need a default value in common-settings.json?

Comment 10

[Krzysztof Mioduszewski[:tauzen]]

Ok, will add it there defaulting to false.

I was looking for all occurrences of 'bluetooth.debugging.enabled' and I've missed the common-settings.json. Thanks for pointing this out.

Comment 11

[Krzysztof Mioduszewski[:tauzen]]

Added default value. Pseudo-locales tested. Gaia-Try errors seem to be unrelated.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/99ed1550a810f7995fa0fd6991d4cf7fdd4ce3c7