Closed
Bug 1058099
Opened 10 years ago
Closed 10 years ago
Intermittent OSX 10.8 leakcheck | 8880 bytes leaked (CacheStorageService, CondVar, Mutex, ReentrantMonitor, nsRunnable, ...)
Categories
(Core :: Networking: Cache, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox32 | --- | wontfix |
firefox33 | --- | fixed |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
firefox-esr24 | --- | unaffected |
firefox-esr31 | --- | unaffected |
b2g-v2.0 | --- | fixed |
b2g-v2.0M | --- | fixed |
b2g-v2.1 | --- | fixed |
b2g-v2.2 | --- | fixed |
People
(Reporter: RyanVM, Assigned: sworkman)
Details
(Keywords: intermittent-failure, memory-leak)
Attachments
(1 file, 1 obsolete file)
903 bytes,
patch
|
sworkman
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
bajaj
:
approval-mozilla-b2g32+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=46634111&tree=Mozilla-Inbound Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-5 on 2014-08-23 11:59:30 PDT for push 870d25b5d7b3 slave: talos-mtnlion-r5-099 12:14:48 INFO - nsTraceRefcnt::DumpStatistics: 1583 entries 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 CacheStorageService (248 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 CondVar (40 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 3 Mutex (96 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 ReentrantMonitor (40 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 nsRunnable (24 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1001 nsStringBuffer (8008 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 5 nsTArray_base (40 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 nsThread (240 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 nsTimerEvent (48 bytes) 12:14:48 INFO - TEST-INFO | leakcheck | leaked 1 nsTimerImpl (96 bytes) 12:14:48 WARNING - TEST-UNEXPECTED-FAIL | leakcheck | 8880 bytes leaked (CacheStorageService, CondVar, Mutex, ReentrantMonitor, nsRunnable, ...)
Reporter | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=46641384&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=46671977&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=46672473&tree=Mozilla-Inbound
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 3•10 years ago
|
||
Steve, I see bug 1054572 in the regression range on inbound. Can you take a look?
Flags: needinfo?(sworkman)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 10•10 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=46945487&tree=Fx-Team
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 13•10 years ago
|
||
Honza, this looks like mPurgeTimer is leaking at shutdown - what do you think? I added mPurgeTimer->Cancel() to ShutdownBackground(). That should work, right?
Attachment #8481721 -
Flags: review?(honzab.moz)
Flags: needinfo?(sworkman)
Assignee | ||
Comment 14•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=028162ade11b https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=028162ade11b
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → sworkman
status-firefox32:
--- → wontfix
status-firefox33:
--- → affected
status-firefox34:
--- → affected
status-firefox-esr24:
--- → unaffected
status-firefox-esr31:
--- → unaffected
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 17•10 years ago
|
||
Comment on attachment 8481721 [details] [diff] [review] v1.0 Cancel CacheStorageService::mPurgeTimer if it's still set during shutdown Review of attachment 8481721 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this is it! Thanks Steve, fantastic hit.
Attachment #8481721 -
Flags: review?(honzab.moz) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 22•10 years ago
|
||
Thanks Honza! https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed4c053e664
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 25•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ed4c053e664
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Reporter | ||
Comment 26•10 years ago
|
||
Please request aurora, beta, and b2g32 approval on this when you get a chance. AFAICT, it affects 32+.
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
status-firefox35:
--- → fixed
Flags: needinfo?(sworkman)
Assignee | ||
Comment 27•10 years ago
|
||
Updated commit line in the patch, ready for uplift pending approval.
Attachment #8481721 -
Attachment is obsolete: true
Attachment #8484373 -
Flags: review+
Flags: needinfo?(sworkman)
Assignee | ||
Comment 28•10 years ago
|
||
Comment on attachment 8484373 [details] [diff] [review] v1.0 Cancel CacheStorageService::mPurgeTimer if it's still set during shutdown Approval Request Comment [Feature/regressing bug #]: 986179 [User impact if declined]: Minor leak on shutdown. [Describe test coverage new/current, TBPL]: Fixes intermittent leak in automated testing; been on m-c for a few days. [Risks and why]: None. [String/UUID change made/needed]: None. Not requesting approval-mozilla-b2g32 - "This flag is now for security issues only."
Attachment #8484373 -
Flags: approval-mozilla-beta?
Attachment #8484373 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 29•10 years ago
|
||
Comment on attachment 8484373 [details] [diff] [review] v1.0 Cancel CacheStorageService::mPurgeTimer if it's still set during shutdown (In reply to Steve Workman [:sworkman] from comment #28) > Not requesting approval-mozilla-b2g32 - "This flag is now for security > issues only." That's bogus copypasta from earlier flags.
Attachment #8484373 -
Flags: approval-mozilla-b2g32?
Updated•10 years ago
|
Attachment #8484373 -
Flags: approval-mozilla-b2g32? → approval-mozilla-b2g32+
Reporter | ||
Comment 30•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/4eb6314a273f
Assignee | ||
Comment 31•10 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #29) > That's bogus copypasta from earlier flags. Cool beans. Thanks for landing.
Updated•10 years ago
|
status-b2g-v2.0M:
--- → fixed
Comment 33•10 years ago
|
||
Comment 32 is not correct, the correct commint on v2.0m is http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/4eb6314a273f
Comment 34•10 years ago
|
||
Comment on attachment 8484373 [details] [diff] [review] v1.0 Cancel CacheStorageService::mPurgeTimer if it's still set during shutdown Beta+ Aurora+
Attachment #8484373 -
Flags: approval-mozilla-beta?
Attachment #8484373 -
Flags: approval-mozilla-beta+
Attachment #8484373 -
Flags: approval-mozilla-aurora?
Attachment #8484373 -
Flags: approval-mozilla-aurora+
Reporter | ||
Comment 35•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ea944d1b7702 https://hg.mozilla.org/releases/mozilla-beta/rev/ede2300e8733
You need to log in
before you can comment on or make changes to this bug.
Description
•