1058111 - The Loop one call functional test fails in websocket code unless the development servers are running

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[:Paolo Amadini]

The Loop one call functional test starts its own servers on ports 5001 and 3001. It seems, however, that the test fails in websocket code, unless the development servers are also running on ports 5000 and 3000.

Comment 1

[Mark Banner (:standard8)]

This is either a loop server issue, or a test-config setup issue.

In the post to /calls/<token> the server is returning a progress url with port 5000. Hence, the set-up for the server which tells it that it should be using 5001 isn't working.

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix functional test setup for Loop to set the correct public server address so that websocket connections work correctly.

One line fix to add a public server address setting for the loop-server. This gets the tests passing again.

I did wonder about fixing the server to set the default port for the public address depending on the PORT env var, but that seemed unnecessarily complicated for something that should probably be specified regardless.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8478442 [details] [diff] [review]
Fix functional test setup for Loop to set the correct public server address so that websocket connections work correctly.

r=dmose, conditional on filing a bug on having the server use PORT as the basis for binding the websocket

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/3d3f1028e29d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d3f1028e29d

Comment 6

[u279076]

Untracking for QA. Please needinfo me to request testing.