Closed
Bug 1058133
Opened 11 years ago
Closed 11 years ago
telemetry for disable/re-enable protection for tracking protection doorhanger
Categories
(Core :: DOM: Security, defect)
Tracking
()
VERIFIED
FIXED
mozilla34
People
(Reporter: mmc, Assigned: mmc)
References
Details
Attachments
(1 file, 2 obsolete files)
|
6.16 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
We should count the number of times these features are activated.
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mmc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8479345 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8479989 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8480677 [details] [diff] [review]
Telemetry for tracking protection events
Review of attachment 8480677 [details] [diff] [review]:
-----------------------------------------------------------------
I couldn't figure out how to count the number of times the doorhanger was actually shown, but I left room in the histogram for it and can do a follow up bug.
Attachment #8480677 -
Flags: review?(bmcbride)
Attachment #8480677 -
Flags: review?(adw)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8480677 [details] [diff] [review]
Telemetry for tracking protection events
Review of attachment 8480677 [details] [diff] [review]:
-----------------------------------------------------------------
The constructor in urlbarBindings.xml should run each time the doorhanger shows, fwiw.
Attachment #8480677 -
Flags: review?(bmcbride)
Attachment #8480677 -
Flags: review?(adw)
Attachment #8480677 -
Flags: review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Blair McBride [:Unfocused] from comment #6)
> Comment on attachment 8480677 [details] [diff] [review]
> Telemetry for tracking protection events
>
> Review of attachment 8480677 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> The constructor in urlbarBindings.xml should run each time the doorhanger
> shows, fwiw.
Thanks, I'll try to get that in next week.
|
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
|
||
Comment 10•11 years ago
|
||
Verified as fixed using:
FF 34.02
Build Id:20141020184313
OS: Win 7 x64, Ubuntu 14.04 x64, Mac Os X 10.9.5
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•