telemetry for disable/re-enable protection for tracking protection doorhanger

VERIFIED FIXED in mozilla34

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mmc, Assigned: mmc)

Tracking

Trunk
mozilla34
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We should count the number of times these features are activated.
Duplicate of this bug: 1058134
Assignee: nobody → mmc
Status: NEW → ASSIGNED
Attachment #8479345 - Attachment is obsolete: true
Attachment #8479989 - Attachment is obsolete: true
Comment on attachment 8480677 [details] [diff] [review]
Telemetry for tracking protection events

Review of attachment 8480677 [details] [diff] [review]:
-----------------------------------------------------------------

I couldn't figure out how to count the number of times the doorhanger was actually shown, but I left room in the histogram for it and can do a follow up bug.
Attachment #8480677 - Flags: review?(bmcbride)
Attachment #8480677 - Flags: review?(adw)
Comment on attachment 8480677 [details] [diff] [review]
Telemetry for tracking protection events

Review of attachment 8480677 [details] [diff] [review]:
-----------------------------------------------------------------

The constructor in urlbarBindings.xml should run each time the doorhanger shows, fwiw.
Attachment #8480677 - Flags: review?(bmcbride)
Attachment #8480677 - Flags: review?(adw)
Attachment #8480677 - Flags: review+
(In reply to Blair McBride [:Unfocused] from comment #6)
> Comment on attachment 8480677 [details] [diff] [review]
> Telemetry for tracking protection events
> 
> Review of attachment 8480677 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The constructor in urlbarBindings.xml should run each time the doorhanger
> shows, fwiw.

Thanks, I'll try to get that in next week.
https://hg.mozilla.org/mozilla-central/rev/63edacfea474
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Verified as fixed using:

FF 34.02
Build Id:20141020184313
OS: Win 7 x64, Ubuntu 14.04 x64, Mac Os X 10.9.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.