Closed Bug 1058335 Opened 5 years ago Closed 5 years ago
_DHash Table clean-ups
Just some clean-ups.
This patch renames all the private PLDHashTable fields to the |mFoo| form. It leaves the public ones alone in order to minimize churn. The patch also fixes the build when PL_DHASHMETER is defined.
Attachment #8478752 - Flags: review?(roc)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
This patch removes the stuff about double-hashing: - the big comment explaining why double-hashing is better than chaining; - the warning that everyone ignores about cases when chaining would be better. We don't have a chaining hash table in the tree, so all this stuff about when you should use chaining is pretty irrelevant.
Attachment #8478753 - Flags: review?(roc)
Attachment #8478752 - Flags: review?(roc) → review+
Attachment #8478753 - Flags: review?(roc) → review+
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=20c629b47ecd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.