1058335 - Some PL_DHashTable clean-ups

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Just some clean-ups.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Used |mFoo| form for PLDHashTable's private members

This patch renames all the private PLDHashTable fields to the |mFoo| form. It
leaves the public ones alone in order to minimize churn.

The patch also fixes the build when PL_DHASHMETER is defined.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove unneeded comments and always-ignored warnings about chaining

This patch removes the stuff about double-hashing:

- the big comment explaining why double-hashing is better than chaining;

- the warning that everyone ignores about cases when chaining would be better.

We don't have a chaining hash table in the tree, so all this stuff about when
you should use chaining is pretty irrelevant.

Comment 3

[Nicholas Nethercote [inactive]]

Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=20c629b47ecd

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ebed11d8a2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/52b9465cc90b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ebed11d8a2b
https://hg.mozilla.org/mozilla-central/rev/52b9465cc90b