Closed Bug 1058348 Opened 5 years ago Closed 5 years ago

"Disable protection for this site" instead of "Disable protection"

Categories

(Core Graveyard :: Security: UI, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: mmc, Assigned: mmc)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → mmc
Status: NEW → ASSIGNED
Comment on attachment 8478739 [details] [diff] [review]
Make disable protection string match mockup (

Review of attachment 8478739 [details] [diff] [review]:
-----------------------------------------------------------------

This string was merged into m-c today. Do I need to rename the label?
Attachment #8478739 - Flags: review?(adw)
(In reply to [:mmc] Monica Chew (please use needinfo) from comment #2)
> This string was merged into m-c today. Do I need to rename the label?

Unfortunately yes.
All right, clearing review flag then. Blair, should this bug just wait on https://bugzilla.mozilla.org/show_bug.cgi?id=1058395 to avoid churn?
Flags: needinfo?(bmcbride)
Attachment #8478739 - Flags: review?(adw)
From the original bug

> The behavior is different. In tracking protection, the disabling persists, and in mixed content, it does not.

This is extremely useful. Can we add it to a localization comment if bug 1058395 is not fixed in this cycle (less than a week away from merge day)?
(In reply to [:mmc] Monica Chew (please use needinfo) from comment #4)
> All right, clearing review flag then. Blair, should this bug just wait on
> https://bugzilla.mozilla.org/show_bug.cgi?id=1058395 to avoid churn?

See if you can grab someone from UX (or a copy editor like Matej) to look at bug 1058395 tomorrow and get a solution quickly recommended. It's much preferable to avoid churn when it comes to strings, but only if it doesn't risk this bug missing the merge.
Flags: needinfo?(bmcbride)
Attachment #8478739 - Attachment is obsolete: true
Attachment #8479295 - Flags: review?(bmcbride)
Attachment #8479295 - Flags: review?(adw)
Attachment #8479295 - Flags: review?(bmcbride)
Attachment #8479295 - Flags: review?(adw)
Attachment #8479295 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/91dddb3a8703
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.