Closed Bug 1058352 Opened 5 years ago Closed 5 years ago

Default search engine probe recording null instead of "other"

Categories

(Firefox for Android :: Settings and Preferences, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox33 --- verified
firefox34 --- verified
fennec 33+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

Follow-up to bug 1007523.
I blame JS. I contemplated changing this to "other" on the JS side, but I want to uplift this patch, and "SearchEngines:Data" has other consumers, so I don't want to risk any regressions.
Attachment #8478742 - Flags: review?(mark.finkle)
Attachment #8478742 - Flags: review?(mark.finkle) → review+
Comment on attachment 8478742 [details] [diff] [review]
Correctly specify "other" instead of "null" for non-built-in search engines

Approval Request Comment
[Feature/regressing bug #]: bug 1007523
[User impact if declined]: not user-facing, but our telemetry data will have less useful data
[Describe test coverage new/current, TBPL]: no automated tests, just landed on fx-team
[Risks and why]: very low-risk, changes string comparison for search engine identifier in settings (only used for telemetry probe)
[String/UUID change made/needed]: none
Attachment #8478742 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/0f0b691f66dd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8478742 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → 33+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.