1058352 - Default search engine probe recording null instead of "other"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

Follow-up to bug 1007523.

Comment 1

[:Margaret Leibovic]

Attachment: Correctly specify "other" instead of "null" for non-built-in search engines

I blame JS. I contemplated changing this to "other" on the JS side, but I want to uplift this patch, and "SearchEngines:Data" has other consumers, so I don't want to risk any regressions.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0f0b691f66dd

Comment 3

[:Margaret Leibovic]

Comment on attachment 8478742 [details] [diff] [review]
Correctly specify "other" instead of "null" for non-built-in search engines

Approval Request Comment
[Feature/regressing bug #]: bug 1007523
[User impact if declined]: not user-facing, but our telemetry data will have less useful data
[Describe test coverage new/current, TBPL]: no automated tests, just landed on fx-team
[Risks and why]: very low-risk, changes string comparison for search engine identifier in settings (only used for telemetry probe)
[String/UUID change made/needed]: none

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f0b691f66dd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e6ee35fe846e