[Settings] Carrier labels of 'Sim Settings' in 'Messaging Settings' is very close to the border

VERIFIED FIXED

Status

Firefox OS
Gaia::Settings
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ericcc, Assigned: eragonj)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.0 unaffected, b2g-v2.1 affected)

Details

(Whiteboard: [p=1])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8478770 [details]
MessagingSettings.png

### STR
1. Open "Messaging Settings" in "Settings"

### Actual
MessagingSettings.png

### Version
Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
(Reporter)

Comment 1

4 years ago
Hi EJ, Could you help with this, thanks.
Flags: needinfo?(ejchen)
Assignee: nobody → ejchen
Flags: needinfo?(ejchen)
Component: Gaia::SMS → Gaia::Settings
Whiteboard: [p=1]
Created attachment 8478791 [details] [review]
patch on master

Arthur, this is a small patch influenced by another refactor work.

Can you help me review this ?! Thanks !! :)
Attachment #8478791 - Flags: review?(arthur.chen)
Comment on attachment 8478791 [details] [review]
patch on master

r=me, thanks!
Attachment #8478791 - Flags: review?(arthur.chen) → review+
(Reporter)

Updated

4 years ago
QA Whiteboard: [COM=Gaia::Settings]
Thanks Arthur ! Merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/e05092fb06c324ed877116c0ced8418fd5501846
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

4 years ago
Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.