Reorganize |KeyboardManager. inputFocusChange()|

RESOLVED FIXED in 2.1 S4 (12sep)

Status

Firefox OS
Gaia::System::Input Mgmt
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mnjul, Assigned: mnjul)

Tracking

(Blocks: 1 bug)

unspecified
2.1 S4 (12sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

Let's reorganize |KeyboardManager.inputFocusChange()| to make it more tangible -- at least the inner activateKeyboard() is unused for some |evt.detail.inputType|s, and we should be able to decouple it.
On my way on this.
Assignee: nobody → jlu
Target Milestone: --- → 2.1 S4 (12sep)
Created attachment 8478883 [details] [review]
Patch (PR @ GitHub)

Hi Tim,

This is a small patch to extract out the inner function of |KeyboardManager. inputFocusChange()| to tidy up things. Could you help review it? Thanks.
Attachment #8478883 - Flags: review?(timdream)
Comment on attachment 8478883 [details] [review]
Patch (PR @ GitHub)

lgtm, sorry for the delay.
Attachment #8478883 - Flags: review?(timdream) → review+
Final testing after rebasing and before landing at TBPL: https://tbpl.mozilla.org/?rev=7e2bafb6293d3377bc9b2e2c4d6ed0fca9ef068d&tree=Gaia-Try
Whiteboard: [p=1]
Master: https://github.com/mozilla-b2g/gaia/commit/d2a1710b3336050a427aca197b44d5821eb68266
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.