Let's reorganize |KeyboardManager.inputFocusChange()| to make it more tangible -- at least the inner activateKeyboard() is unused for some |evt.detail.inputType|s, and we should be able to decouple it.
On my way on this.
Assignee: nobody → jlu
Target Milestone: --- → 2.1 S4 (12sep)
Created attachment 8478883 [details] [review] Patch (PR @ GitHub) Hi Tim, This is a small patch to extract out the inner function of |KeyboardManager. inputFocusChange()| to tidy up things. Could you help review it? Thanks.
Attachment #8478883 - Flags: review?(timdream)
Attachment #8478883 - Flags: review?(timdream) → review+
Final testing after rebasing and before landing at TBPL: https://tbpl.mozilla.org/?rev=7e2bafb6293d3377bc9b2e2c4d6ed0fca9ef068d&tree=Gaia-Try
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.