Closed
Bug 1058388
Opened 12 years ago
Closed 12 years ago
Remove NS_COM_GLUE
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
70.56 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
glandium thinks that NS_COM_GLUE is mostly a no-op these days.
bsmedberg, do you think removing it would be ok?
|
Assignee | |
Updated•12 years ago
|
Flags: needinfo?(benjamin)
|
||
Comment 1•12 years ago
|
||
Yes, now that we link the guts of xpcom into libxul and hidden-visibility is the default on all platforms, NS_COM_GLUE is no longer necessary.
Flags: needinfo?(benjamin)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8479464 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8479464 [details] [diff] [review]
Remove NS_COM_GLUE and IMETHOD_VISIBILITY
It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h. Did you mean to?
Attachment #8479464 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
> It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h.
Good catch. I will remove them too.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=985fa924f77b
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•