1058388 - Remove NS_COM_GLUE

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

glandium thinks that NS_COM_GLUE is mostly a no-op these days.

bsmedberg, do you think removing it would be ok?

Comment 1

[Benjamin Smedberg]

Yes, now that we link the guts of xpcom into libxul and hidden-visibility is the default on all platforms, NS_COM_GLUE is no longer necessary.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove NS_COM_GLUE and IMETHOD_VISIBILITY

Comment 3

[Benjamin Smedberg]

Comment on attachment 8479464 [details] [diff] [review]
Remove NS_COM_GLUE and IMETHOD_VISIBILITY

It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h. Did you mean to?

Comment 4

[Nicholas Nethercote [inactive]]

> It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h.

Good catch. I will remove them too.

Comment 5

[Nicholas Nethercote [inactive]]

Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=985fa924f77b

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b276ce875275

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b276ce875275