Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla34
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

glandium thinks that NS_COM_GLUE is mostly a no-op these days.

bsmedberg, do you think removing it would be ok?
Flags: needinfo?(benjamin)
Yes, now that we link the guts of xpcom into libxul and hidden-visibility is the default on all platforms, NS_COM_GLUE is no longer necessary.
Flags: needinfo?(benjamin)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8479464 [details] [diff] [review]
Remove NS_COM_GLUE and IMETHOD_VISIBILITY

It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h. Did you mean to?
Attachment #8479464 - Flags: review?(benjamin) → review+
> It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h.

Good catch. I will remove them too.
https://hg.mozilla.org/mozilla-central/rev/b276ce875275
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.