Closed Bug 1058388 Opened 7 years ago Closed 7 years ago
glandium thinks that NS_COM_GLUE is mostly a no-op these days. bsmedberg, do you think removing it would be ok?
Yes, now that we link the guts of xpcom into libxul and hidden-visibility is the default on all platforms, NS_COM_GLUE is no longer necessary.
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8479464 [details] [diff] [review] Remove NS_COM_GLUE and IMETHOD_VISIBILITY It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h. Did you mean to?
Attachment #8479464 - Flags: review?(benjamin) → review+
> It doesn't look like you removed the IMETHOD_VISIBILITY bits from nscore.h. Good catch. I will remove them too.
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=985fa924f77b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.