1058419 - [Devices][Storage][Flame] SD card is an option for default media location when no SD card inserted

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Alison Shiue]

Device    Flame
Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1

No SD card be inserted at device

STR:
1. New flash device with the latest build
2. Go to Settings -> Media storage -> Advanced section

Expected result:
Default media location is Internal and user could not change it

Actual result:
User can change the media location to SD card

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:

Comment 2

[[e-mail], [e-mail]]

Will have to give a patch to disable default media location selection.

Comment 3

[[e-mail], [e-mail]]

Attachment: pull request 23881

Hi Arthur, could you please help to review my pull request? The patch is aiming to update default media location selection menu while settings::mediaStorage page init. And I will give another patch for fixing bug 1057989(default media location not update while remove SD card in the background). Thanks.

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8486948 [details] [review]
pull request 23881

Miss to set review flag.

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 8486948 [details] [review]
pull request 23881

Since Arthur is PTO, I request reviewer from EJ.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8486948 [details] [review]
pull request 23881

@Ian,

basically this patch is good to me.

I left some comments on Github and please go check it there.

Thanks !

Comment 7

[[e-mail], [e-mail]]

Comment on attachment 8486948 [details] [review]
pull request 23881

Thanks for EJ's reviewing effort. I have updated my patch with your suggestion. Please help to review it again:)

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8486948 [details] [review]
pull request 23881

Thanks Ian,

let's refactor this panel in https://bugzilla.mozilla.org/show_bug.cgi?id=973451

Comment 9

[[e-mail], [e-mail]]

Since the pr is landed, we can close the issue now.

Gaia/master:  5677c70ff8372c5d5a83f002e248503907b376e6

Comment 10

[[e-mail], [e-mail]]

Comment on attachment 8486948 [details] [review]
pull request 23881

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1058419
[User impact] if declined: SD card is an option for default media location when no SD card inserted. So that data will be saved on none existed SD card.
[Testing completed]: Passed on Try-server
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks EJ for reviewing the patch!

Comment 12

[[:fabrice] Fabrice Desré]

Arthur, can you add new tests?

Comment 13

[howie [:howie]]

ni Ian for Comment 12

Comment 14

[[e-mail], [e-mail]]

Per offline discussion before, we plan to add unit test after refactor work of media storage panel completely(Bug 973451). For the code base currently, it's hard to do some unit test. Because UI refreshing and logic control are depended too much. In case of Gij/Gip, the default media location menu is always disabled in b2g-desktop. So that we cannot make the user story to construct the integration test.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/d422b9850a00410881e8c433cab0a24fff300a95

Comment 16

[Alison Shiue]

Verified on

[2.2]
Gaia-Rev        03d7bcad57ea281869976a9aed0a38849f7c8bc5
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/1735ff2bb23e
Build-ID        20140924160204
Version         35.0a1

[2.1]
Gaia-Rev        8061ab487d42cbc49b329fd68b9ca90e0fe477e6
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/e970bc96f8b5
Build-ID        20140925000204
Version         34.0a2

Comment 17

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Default storage options greyed out and when SD card is not inserted in device.