Closed Bug 1058484 Opened 10 years ago Closed 10 years ago

"Write a Review"/"Sign in to Review" buttons needs more left/right padding

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Tracking

(Not tracked)

VERIFIED FIXED
2014-09-09

People

(Reporter: cvan, Assigned: spasovski)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Priority: -- → P3
Assignee: nobody → dspasovski
They seem inline with the new style guide:

http://pwalm.github.io/marketplace-style-guides/buttons.html

Having said that I agree the spacing should be even top/bottom vs left/right spacing.
Philip your thoughts?
Flags: needinfo?(pwalmsley)
It is inline with the style guide but looks kind of weird, doesn't it? Let's make it 30px on either side of these longer string buttons. I'll update the style guide to reflect these changes (of which I'm thinking there will be a few, button wise).
Flags: needinfo?(pwalmsley)
https://github.com/mozilla/fireplace/pull/644
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-09-09
Verified as fixed : http://screencast.com/t/syWC1egx
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: