Line-height is off for reviews stars/text on search results/detail pages

VERIFIED FIXED in 2015-03-17

Status

Marketplace
Consumer Pages
P4
minor
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: cvan, Assigned: Trishul)

Tracking

({regression})

2015-03-17
regression
Points:
---

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
This issue predated the feed.

Notice the 2px padding below the review text, causing the review count to not match the baseline of the stars:

https://marketplace.firefox.com/search?q=
http://i.imgur.com/LvFtLra.png

https://marketplace.firefox.com/app/connecta2?src=search
http://i.imgur.com/CwEIt0f.png

Updated

3 years ago
Priority: -- → P4

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Target Milestone: --- → 2015-03-17

Comment 1

3 years ago
Verified in FFOS 2.0(Flame) in marketplace stage.
The reviews count was removed from the search result page. On an app detail page this is still reproducing.
Please view this screenshot: http://screencast.com/t/RK74B7Qc
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 2

2 years ago
New designs
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
nvm
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

2 years ago
Whiteboard: [goodfirstbug]

Updated

2 years ago
Whiteboard: [goodfirstbug] → [good first bug]
(Assignee)

Updated

2 years ago
Assignee: nobody → trishul.goel
(Assignee)

Comment 4

2 years ago
Created attachment 8638913 [details] [review]
Pull Request

For app details page.
(Assignee)

Comment 5

2 years ago
Merged #1408.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED

Comment 6

2 years ago
Verified as fixed in marketplace-dev.allizom.org.
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.