[settings] move root panel screen lock item into panels/root

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eragonj, Assigned: eragonj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
We have to move screen lock related function into panels/root.
Comment on attachment 8478927 [details] [review]
patch on master

Arthur, can you help me review this small patch ?! Thanks :)
Attachment #8478927 - Flags: review?(arthur.chen)
Blocks: 1024285
No longer blocks: 1027465
Comment on attachment 8478927 [details] [review]
patch on master

r+ with the comments addressed, thanks!
Attachment #8478927 - Flags: review?(arthur.chen) → review+
Comment on attachment 8478927 [details] [review]
patch on master

Hi Zac,

this is one line CSS change in python, can you help me review it ?! THanks :)
Attachment #8478927 - Flags: review?(zcampbell)

Comment 6

4 years ago
Comment on attachment 8478927 [details] [review]
patch on master

r+
Attachment #8478927 - Flags: review?(zcampbell) → review+
Thanks all, this was merged to Gaia/master : https://github.com/mozilla-b2g/gaia/commit/c3860fc4c5050ffff5d7a179015589dc2ac0bc63
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.