Closed Bug 1058521 Opened 10 years ago Closed 10 years ago

[settings] move root panel screen lock item into panels/root

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: eragonj, Assigned: eragonj)

References

Details

Attachments

(1 file)

patch on master
46 bytes, text/x-github-pull-request
arthurcc
: review+
zcampbell
: review+
Details | Review 
      No description provided.
We have to move screen lock related function into panels/root.
Comment on attachment 8478927 [details] [review]
patch on master

Arthur, can you help me review this small patch ?! Thanks :)
Attachment #8478927 - Flags: review?(arthur.chen)
Comment on attachment 8478927 [details] [review]
patch on master

r+ with the comments addressed, thanks!
Attachment #8478927 - Flags: review?(arthur.chen) → review+
Comment on attachment 8478927 [details] [review]
patch on master

Hi Zac,

this is one line CSS change in python, can you help me review it ?! THanks :)
Attachment #8478927 - Flags: review?(zcampbell)
Comment on attachment 8478927 [details] [review]
patch on master

r+
Attachment #8478927 - Flags: review?(zcampbell) → review+
Thanks all, this was merged to Gaia/master : https://github.com/mozilla-b2g/gaia/commit/c3860fc4c5050ffff5d7a179015589dc2ac0bc63
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: