105853 - new <wizard/> has some navigation problems

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[racham]

I have used a test case wizardtest.xul (will post in the next update) &
triggered wizard from MailNews.

Procedure followed to add and trigger the wizard :

Added to new test case i.e., wizardtest.xul (will post in the next update) as
messsenger.jar and opened it in place of accountwizard (modifying chrome urls in
http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/accountUtils.js#185
to point to wizardtest.xul) from AccountCentral page (or you can use
Tasks->Mail&Newsgropus->Mail&Newsgroups Account Settings->New Account).

Here are the set of navigation issues I have noticed :

1. Hitting 'Enter' sometimes jumps ahead 2 pages. Noticed consistently when
focus  is lost initially and gained via cancel button activity. 
OK case : Navigation is fine with mouse clicks.

2. Hitting 'Enter' on back button jumps 2 pages back consistently. 
OK case : Navigation is fine with mouse clicks.

3. Clicking on Cancel+OK, using mouse, does not close the window. 
OK case : Tabbing onto Cancel and hitting OK closes the window.

4. Clicking on Finish, using mouse, does not close the window.
OK case : Tabbing onto Finish and hitting 'Enter' closes the window.

5. Looks like there is call to window.close() on when the last page is displayed
while navigating using tabs & 'Enter'. It seems to be a failed case. Otherwise
window would have been closed. Found via debug statements in wizard.xml.
OK case : Mouse click navigation doesn't do this.

6. Clicking on 'X' of the wizard window gives the following js exception

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._wizard has no properties"]' when calli
ng method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x80570021 (NS_ERROR_
XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

do I need an explicit handlers similar to onclose handler..?

7. Hitting 'Escape' button or click/hitting on 'Cancel' button gets confirmation
dialog with focus on 'OK' button. Now tab onto 'Cancel' button on this
confirmation dialog. Hit 'Enter'. Wizard is closed. It shouldn't close.
OK case : Clicking on 'Cancel' button on confirmation window does not close the
wizard window.

Please comment and ignore if there are any invalid problems among the reported.

Comment 1

[racham]

Attachment: wizardtest.xul file used in my testing (5 wizardpages)

Comment 2

[racham]

Adding mailtrack,nsbeta1 keywords.

Comment 3

[Joe Hewitt (gone)]

fixed by 101876 fix

Comment 4

[racham]

I still see the following. Looks like the event is not propagated properly.
Reopening for getting the resolution on the following issue.

7. Hitting 'Escape' button or click/hitting on 'Cancel' button gets confirmation
dialog with focus on 'OK' button. Now tab onto 'Cancel' button on this
confirmation dialog. Hit 'Enter'. Wizard is closed. It shouldn't close.
OK case : Clicking on 'Cancel' button on confirmation window does not close the
wizard window.

Comment 5

[racham]

Reopening now.

Comment 6

[Joe Hewitt (gone)]

This last issue is not a wizard bug, it is a bug in the old dialogs.  Hitting
enter in that dialog causes "ok" to be fired, thus closing the wizard. When
blake finishes converting all dialogs to use the new <dialog/> tag, that will be
fixed.

Comment 7

[racham]

Thanks for clarification.

Wizard looks great now.