1058531 - Turn coverage checker off by default when using runtests.sh

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

https://treeherder-service.readthedocs.org/en/latest/installation.html recommends using runtests.sh, which by default enables the coverage checker.

This presumably takes longer, and adds cruft to the srcdir & also the console output - and is unlikely needed (a) most of the time, and (b) by someone new using the helper scripts rather than test.py directly.

Let's turn it off by default :-)

Comment 1

[Mauro Doglio [:mdoglio]]

I think we could even get rid of runtests.sh itself, using python setup.py test instead.

Comment 2

[Ed Morley [:emorley]]

(In reply to Mauro Doglio [:mdoglio] from comment #1)
> I think we could even get rid of runtests.sh itself, using python setup.py
> test instead.

Yeah agreed - I'd happily remove it and just add some more instructions to the RTD pages, for those not used to py.test.

Comment 3

[Ed Morley [:emorley]]

Attachment: Don't enable pytest coverage checker in runtests.sh

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8673697 [details] [review]
Don't enable pytest coverage checker in runtests.sh

Thanks!

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5d3bce9802347929d0263e91d54f2c0130b01e5e
Bug 1058531 - Don't enable pytest coverage checker in runtests.sh

It shouldn't be enabled by default IMO. For better overall visibility,
we should be using something like coveralls or codeclimate.