1058538 - "DuckDuckGo Plus" add-on can't install toolbar button when e10s is enabled (`windows is null` exception)

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[iamjayakumars]

Its installed and showing in Addons.

* No icons in Menu or Customize Menu too
* Its not displaying in search

Just installed, nothing works.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140825030205 CSet: daa84204a11a

Comment 1

[Chris Peterson [:cpeterson]]

hi Gabriel, if your team has any questions about add-on support for multiprocess Firefox (e10s), just drop by the #e10s IRC channel on irc.mozilla.org. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

* Ally or Zombie: the CuddlefishLoader looks like part of the Add-on SDK and is a common source of e10s problems for add-ons. Can we fix the CuddlefishLoader itself or shim it in Gecko?

The problem is that the DDG add-on hits a `windows is null` exception when trying to install the toolbar button. If I install the add-on without e10s enabled and then enable e10s, the DDG toolbar button works correctly.

> console.error: ddg_for_firefox: 
>   Message: TypeError: window is null
>   Stack:
>     addSelectionListener@resource://gre/modules/commonjs/sdk/selection.js:342:7
> @resource://gre/modules/commonjs/sdk/selection.js:406:1
> CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129:18
> @resource://gre/modules/commonjs/sdk/context-menu.js:27:19
> CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129:18
> @resource://jid1-zadieub7xozojw-at-jetpack/ddg_for_firefox/lib/ddg-askdax.js:17:19
> CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129:18
> @resource://jid1-zadieub7xozojw-at-jetpack/ddg_for_firefox/lib/main.js:28:14
> CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129:18
> run@resource://gre/modules/commonjs/sdk/addon/runner.js:138:19
> startup/</<@resource://gre/modules/commonjs/sdk/addon/runner.js:81:7
> Handler.prototype.process@resource://gre/modules/Promise-backend.js:865:23
> this.PromiseWalker.walkerLoop@resource://gre/modules/Promise-backend.js:744:7

Comment 2

[Tomislav Jovanovic :zombie]

Cuddlefish is just the JS module loader used for SDK addons, and doesn't really have much to do with e10s, it just appears in most (all?) stack traces involving SDK code.

the problem here is in the selection.js module, which throws immediately upon loading. i filed bug 1060695 for that.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been contacted through AMO.

Comment 5

[Allison Naaktgeboren :ally]

Telemetry is reporting that DDG regularly throws an exception in context-menu.js line 690

Comment 6

[Allison Naaktgeboren :ally]

might be work noting that the google translator addon also throws in context-menu.js ln 690. These could be very different files, but this looks suspicious to me.

Comment 7

[Allison Naaktgeboren :ally]

translate this also throws in context-menu.js.

Comment 8

[Gabor Krizsanits (INACTIVE)]

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #6)
> might be work noting that the google translator addon also throws in
> context-menu.js ln 690. These could be very different files, but this looks
> suspicious to me.

Seems to me that this is from SDK code. The updated exception line number points here: http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/context-menu.js#689

messageManager.sendAsyncMessage("sdk/contextmenu/createitems",...

This line seems to throw from multiple addons. How bad it is if this line fails? Should we look into this? Or is this a known issue maybe?

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

I just gave this add-on a try and it's working correctly on Nightly. Maybe this bug should be closed and the SDK issue should be moved to a separate bug.

Comment 10

[Jerod Lycett]

It appears to be working fine for me in Aurora.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Closing this bug. The issue in comment #8 should be moved to a different bug, if it's really a problem.